Skip to content

Commit 3506777

Browse files
committed
don't override auto refresh for appapi
1 parent c730ace commit 3506777

File tree

7 files changed

+29
-17
lines changed

7 files changed

+29
-17
lines changed

build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ plugins {
1515
}
1616

1717
group = "com.adamratzman"
18-
version = "3.0.02"
18+
version = "3.0.03"
1919

2020
java {
2121
withSourcesJar()

src/commonMain/kotlin/com.adamratzman.spotify/Builder.kt

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,17 @@ import kotlinx.serialization.json.Json
1818

1919
// Kotlin DSL builders
2020

21-
@Deprecated("Builder methods are now found in SpotifyApi", ReplaceWith("SpotifyApi.spotifyAppApi"))
2221
fun spotifyAppApi(clientId: String, clientSecret: String, block: SpotifyAppApiBuilder.() -> Unit = {}) =
23-
SpotifyApi.spotifyAppApi(clientId, clientSecret, block)
22+
spotifyAppApi(clientId, clientSecret, block)
2423

25-
@Deprecated("Builder methods are now found in SpotifyApi", ReplaceWith("SpotifyApi.spotifyAppApi"))
2624
fun spotifyAppApi(block: SpotifyAppApiBuilder.() -> Unit) =
27-
SpotifyApi.spotifyAppApi(block)
25+
spotifyAppApi(block)
2826

29-
@Deprecated("Builder methods are now found in SpotifyApi", ReplaceWith("SpotifyApi.spotifyClientApi"))
3027
fun spotifyAppApi(clientId: String, clientSecret: String, redirectUri: String, block: SpotifyClientApiBuilder.() -> Unit = {}) =
31-
SpotifyApi.spotifyClientApi(clientId, clientSecret, redirectUri, block)
28+
spotifyClientApi(clientId, clientSecret, redirectUri, block)
3229

33-
@Deprecated("Builder methods are now found in SpotifyApi", ReplaceWith("SpotifyApi.spotifyClientApi"))
3430
fun spotifyAppApi(block: SpotifyClientApiBuilder.() -> Unit) =
35-
SpotifyApi.spotifyClientApi(block)
31+
spotifyClientApi(block)
3632

3733
/**
3834
* Spotify API builder
@@ -447,7 +443,7 @@ class SpotifyAppApiBuilder(
447443
authorization.token!!,
448444
options.useCache,
449445
options.cacheLimit,
450-
false,
446+
options.automaticRefresh,
451447
options.retryWhenRateLimited,
452448
options.enableLogger,
453449
options.testTokenValidity,
@@ -466,7 +462,7 @@ class SpotifyAppApiBuilder(
466462
),
467463
options.useCache,
468464
options.cacheLimit,
469-
false,
465+
options.automaticRefresh,
470466
options.retryWhenRateLimited,
471467
options.enableLogger,
472468
options.testTokenValidity,
@@ -483,7 +479,7 @@ class SpotifyAppApiBuilder(
483479
Token("", "", 0, authorization.refreshTokenString!!),
484480
options.useCache,
485481
options.cacheLimit,
486-
false,
482+
options.automaticRefresh,
487483
options.retryWhenRateLimited,
488484
options.enableLogger,
489485
options.testTokenValidity,
@@ -502,7 +498,7 @@ class SpotifyAppApiBuilder(
502498
token,
503499
options.useCache,
504500
options.cacheLimit,
505-
false,
501+
options.automaticRefresh,
506502
options.retryWhenRateLimited,
507503
options.enableLogger,
508504
options.testTokenValidity,

src/commonMain/kotlin/com.adamratzman.spotify/http/Endpoints.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
package com.adamratzman.spotify.http
33

44
import com.adamratzman.spotify.SpotifyApi
5-
import com.adamratzman.spotify.SpotifyClientApi
65
import com.adamratzman.spotify.SpotifyException
76
import com.adamratzman.spotify.SpotifyException.BadRequestException
87
import com.adamratzman.spotify.SpotifyException.TimeoutException

src/commonMain/kotlin/com.adamratzman.spotify/utils/Utils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ internal fun <T : ResultEnum> Array<T>.match(identifier: String) =
2424

2525
internal expect fun formatDate(format: String, date: Long): String
2626

27-
expect fun <T> runBlocking(coroutineCode: suspend () -> T): T
27+
internal expect fun <T> runBlocking(coroutineCode: suspend () -> T): T

src/commonTest/kotlin/com.adamratzman/spotify/utilities/UtilityTests.kt

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import com.adamratzman.spotify.api
88
import com.adamratzman.spotify.block
99
import com.adamratzman.spotify.getEnvironmentVariable
1010
import kotlin.test.assertFailsWith
11+
import kotlin.test.assertTrue
1112
import kotlinx.coroutines.GlobalScope
1213
import org.spekframework.spek2.Spek
1314
import org.spekframework.spek2.style.specification.describe
@@ -65,6 +66,22 @@ class UtilityTests : Spek({
6566
}
6667
}.build()
6768
}
69+
70+
it("Automatic refresh") {
71+
val api = spotifyAppApi {
72+
credentials {
73+
clientId = getEnvironmentVariable("SPOTIFY_CLIENT_ID")
74+
clientSecret = getEnvironmentVariable("SPOTIFY_CLIENT_SECRET")
75+
}
76+
}.build()
77+
78+
api.token = api.token.copy(expiresIn = -1)
79+
val currentToken = api.token
80+
81+
api.browse.getAvailableGenreSeeds().complete()
82+
83+
assertTrue(api.token.accessToken != currentToken.accessToken)
84+
}
6885
}
6986
}
7087
})

src/jsMain/kotlin/com/adamratzman/spotify/utils/Concurrency.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import kotlinx.coroutines.delay
77
import kotlinx.coroutines.launch
88
import kotlinx.coroutines.promise
99

10-
actual inline fun <T> runBlocking(crossinline coroutineCode: suspend () -> T): dynamic {
10+
internal actual inline fun <T> runBlocking(crossinline coroutineCode: suspend () -> T): dynamic {
1111
return GlobalScope.promise { coroutineCode() }
1212
}
1313

src/jvmMain/kotlin/com/adamratzman/spotify/utils/Concurrency.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import kotlinx.coroutines.delay
88
import kotlinx.coroutines.launch
99
import kotlinx.coroutines.runBlocking as kRunBlocking
1010

11-
actual inline fun <T> runBlocking(crossinline coroutineCode: suspend () -> T): T = kRunBlocking {
11+
internal actual inline fun <T> runBlocking(crossinline coroutineCode: suspend () -> T): T = kRunBlocking {
1212
coroutineCode()
1313
}
1414

0 commit comments

Comments
 (0)