Skip to content

Commit 4e5e506

Browse files
committed
replace market?.name with getSpotifyId()
1 parent bfa7de9 commit 4e5e506

File tree

8 files changed

+26
-21
lines changed

8 files changed

+26
-21
lines changed

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/client/ClientLibraryApi.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import com.adamratzman.spotify.models.serialization.toList
1818
import com.adamratzman.spotify.models.serialization.toNonNullablePagingObject
1919
import com.adamratzman.spotify.utils.Market
2020
import com.adamratzman.spotify.utils.encodeUrl
21+
import com.adamratzman.spotify.utils.getSpotifyId
2122
import kotlinx.serialization.builtins.ListSerializer
2223
import kotlinx.serialization.builtins.serializer
2324

@@ -49,7 +50,7 @@ public class ClientLibraryApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
4950
requireScopes(SpotifyScope.UserLibraryRead)
5051

5152
return get(
52-
endpointBuilder("/me/tracks").with("limit", limit).with("offset", offset).with("market", market?.name)
53+
endpointBuilder("/me/tracks").with("limit", limit).with("offset", offset).with("market", market?.getSpotifyId())
5354
.toString()
5455
).toNonNullablePagingObject(SavedTrack.serializer(), api = api, json = json)
5556
}
@@ -76,7 +77,7 @@ public class ClientLibraryApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
7677
requireScopes(SpotifyScope.UserLibraryRead)
7778

7879
return get(
79-
endpointBuilder("/me/albums").with("limit", limit).with("offset", offset).with("market", market?.name)
80+
endpointBuilder("/me/albums").with("limit", limit).with("offset", offset).with("market", market?.getSpotifyId())
8081
.toString()
8182
).toNonNullablePagingObject(SavedAlbum.serializer(), api = api, json = json)
8283
}

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/client/ClientPlayerApi.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import com.adamratzman.spotify.models.toShowUri
3030
import com.adamratzman.spotify.models.toTrackUri
3131
import com.adamratzman.spotify.utils.Market
3232
import com.adamratzman.spotify.utils.catch
33+
import com.adamratzman.spotify.utils.getSpotifyId
3334
import com.adamratzman.spotify.utils.jsonMap
3435
import kotlinx.serialization.builtins.ListSerializer
3536
import kotlinx.serialization.json.JsonArray
@@ -87,7 +88,7 @@ public class ClientPlayerApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
8788
getNullable(
8889
endpointBuilder("/me/player")
8990
.with("additional_types", additionalTypes.joinToString(",") { it.identifier })
90-
.with("market", market?.name)
91+
.with("market", market?.getSpotifyId())
9192
.toString()
9293
)?.toObject(CurrentlyPlayingContext.serializer(), api, json)
9394
}
@@ -162,7 +163,7 @@ public class ClientPlayerApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
162163
getNullable(
163164
endpointBuilder("/me/player/currently-playing")
164165
.with("additional_types", additionalTypes.joinToString(",") { it.identifier })
165-
.with("market", market?.name)
166+
.with("market", market?.getSpotifyId())
166167
.toString()
167168
)
168169
}?.toObject(CurrentlyPlayingObject.serializer(), api, json)

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/pub/AlbumApi.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import com.adamratzman.spotify.models.serialization.toObject
1414
import com.adamratzman.spotify.utils.Market
1515
import com.adamratzman.spotify.utils.catch
1616
import com.adamratzman.spotify.utils.encodeUrl
17+
import com.adamratzman.spotify.utils.getSpotifyId
1718

1819
/**
1920
* Endpoints for retrieving information about one or more albums from the Spotify catalog.
@@ -35,7 +36,7 @@ public class AlbumApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
3536
get(
3637
endpointBuilder("/albums/${AlbumUri(album).id}").with(
3738
"market",
38-
market?.name
39+
market?.getSpotifyId()
3940
).toString()
4041
).toObject(Album.serializer(), api, json)
4142
}
@@ -56,7 +57,7 @@ public class AlbumApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
5657
return bulkStatelessRequest(20, albums.toList()) { chunk ->
5758
get(
5859
endpointBuilder("/albums").with("ids", chunk.joinToString(",") { AlbumUri(it).id.encodeUrl() })
59-
.with("market", market?.name).toString()
60+
.with("market", market?.getSpotifyId()).toString()
6061
).toObject(AlbumsResponse.serializer(), api, json).albums
6162
}.flatten()
6263
}
@@ -83,7 +84,7 @@ public class AlbumApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
8384
endpointBuilder("/albums/${AlbumUri(album).id.encodeUrl()}/tracks").with("limit", limit).with(
8485
"offset",
8586
offset
86-
).with("market", market?.name)
87+
).with("market", market?.getSpotifyId())
8788
.toString()
8889
).toNonNullablePagingObject(SimpleTrack.serializer(), api = api, json = json)
8990
}

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/pub/ArtistApi.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public class ArtistApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
8989
endpointBuilder("/artists/${ArtistUri(artist).id.encodeUrl()}/albums").with("limit", limit).with(
9090
"offset",
9191
offset
92-
).with("market", market?.name)
92+
).with("market", market?.getSpotifyId())
9393
.with("include_groups", include.joinToString(",") { it.keyword }).toString()
9494
).toNonNullablePagingObject(SimpleAlbum.serializer(), null, api, json)
9595

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/pub/BrowseApi.kt

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ import com.adamratzman.spotify.models.SpotifyCategory
1818
import com.adamratzman.spotify.models.serialization.toInnerArray
1919
import com.adamratzman.spotify.models.serialization.toNonNullablePagingObject
2020
import com.adamratzman.spotify.models.serialization.toObject
21-
import com.adamratzman.spotify.utils.Locale
22-
import com.adamratzman.spotify.utils.Market
21+
import com.adamratzman.spotify.utils.*
2322
import com.adamratzman.spotify.utils.encodeUrl
2423
import com.adamratzman.spotify.utils.formatDate
2524
import kotlinx.serialization.Serializable
@@ -66,7 +65,7 @@ public class BrowseApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
6665
market: Market? = null
6766
): PagingObject<SimpleAlbum> = get(
6867
endpointBuilder("/browse/new-releases").with("limit", limit)
69-
.with("offset", offset).with("country", market?.name).toString()
68+
.with("offset", offset).with("country", market?.getSpotifyId()).toString()
7069
).toNonNullablePagingObject(SimpleAlbum.serializer(), "albums", api = api, json = json)
7170

7271
/**
@@ -98,7 +97,7 @@ public class BrowseApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
9897
): FeaturedPlaylists = get(
9998
endpointBuilder("/browse/featured-playlists").with("limit", limit).with("offset", offset).with(
10099
"market",
101-
market?.name
100+
market?.getSpotifyId()
102101
).with("locale", locale).with("timestamp", timestamp?.let { formatDate(it) }).toString()
103102
).toObject(FeaturedPlaylists.serializer(), api, json)
104103

@@ -127,7 +126,7 @@ public class BrowseApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
127126
): PagingObject<SpotifyCategory> = get(
128127
endpointBuilder("/browse/categories").with("limit", limit).with("offset", offset).with(
129128
"market",
130-
market?.name
129+
market?.getSpotifyId()
131130
).with("locale", locale).toString()
132131
).toNonNullablePagingObject(SpotifyCategory.serializer(), "categories", api = api, json = json)
133132

@@ -151,7 +150,7 @@ public class BrowseApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
151150
market: Market? = null,
152151
locale: Locale? = null
153152
): SpotifyCategory = get(
154-
endpointBuilder("/browse/categories/${categoryId.encodeUrl()}").with("market", market?.name)
153+
endpointBuilder("/browse/categories/${categoryId.encodeUrl()}").with("market", market?.getSpotifyId())
155154
.with("locale", locale).toString()
156155
).toObject(SpotifyCategory.serializer(), api, json)
157156

@@ -177,7 +176,7 @@ public class BrowseApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
177176
endpointBuilder("/browse/categories/${categoryId.encodeUrl()}/playlists")
178177
.with("limit", limit)
179178
.with("offset", offset)
180-
.with("country", market?.name).toString()
179+
.with("country", market?.getSpotifyId()).toString()
181180
).toNonNullablePagingObject((SimplePlaylist.serializer()), "playlists", api = api, json = json)
182181

183182
/**
@@ -285,7 +284,7 @@ public class BrowseApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
285284
)
286285
}
287286

288-
val builder = endpointBuilder("/recommendations").with("limit", limit).with("market", market?.name)
287+
val builder = endpointBuilder("/recommendations").with("limit", limit).with("market", market?.getSpotifyId())
289288
.with("seed_artists", seedArtists?.joinToString(",") { ArtistUri(it).id.encodeUrl() })
290289
.with("seed_genres", seedGenres?.joinToString(",") { it.encodeUrl() })
291290
.with("seed_tracks", seedTracks?.joinToString(",") { PlayableUri(it).id.encodeUrl() })

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/pub/PlaylistApi.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import com.adamratzman.spotify.models.serialization.toObject
1919
import com.adamratzman.spotify.utils.Market
2020
import com.adamratzman.spotify.utils.catch
2121
import com.adamratzman.spotify.utils.encodeUrl
22+
import com.adamratzman.spotify.utils.getSpotifyId
2223
import kotlinx.serialization.builtins.ListSerializer
2324

2425
/**
@@ -75,7 +76,7 @@ public open class PlaylistApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
7576
public suspend fun getPlaylist(playlist: String, market: Market? = null): Playlist? = catch {
7677
get(
7778
endpointBuilder("/playlists/${PlaylistUri(playlist).id.encodeUrl()}")
78-
.with("market", market?.name).toString()
79+
.with("market", market?.getSpotifyId()).toString()
7980
).toObject(Playlist.serializer(), api, json)
8081
}
8182

@@ -102,7 +103,7 @@ public open class PlaylistApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
102103
market: Market? = null
103104
): PagingObject<PlaylistTrack> = get(
104105
endpointBuilder("/playlists/${PlaylistUri(playlist).id.encodeUrl()}/tracks").with("limit", limit)
105-
.with("offset", offset).with("market", market?.name).toString()
106+
.with("offset", offset).with("market", market?.getSpotifyId()).toString()
106107
)
107108
.toNonNullablePagingObject(PlaylistTrack.serializer(), null, api, json)
108109

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/pub/SearchApi.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import com.adamratzman.spotify.models.serialization.toNonNullablePagingObject
2020
import com.adamratzman.spotify.models.serialization.toNullablePagingObject
2121
import com.adamratzman.spotify.utils.Market
2222
import com.adamratzman.spotify.utils.encodeUrl
23+
import com.adamratzman.spotify.utils.getSpotifyId
2324
import kotlinx.serialization.builtins.MapSerializer
2425
import kotlinx.serialization.builtins.serializer
2526
import kotlinx.serialization.json.JsonObject
@@ -345,7 +346,7 @@ public open class SearchApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
345346
return endpointBuilder("/search")
346347
.with("q", queryString.encodeUrl())
347348
.with("type", types.joinToString(",") { it.id })
348-
.with("market", market?.name).with("limit", limit).with("offset", offset)
349+
.with("market", market?.getSpotifyId()).with("limit", limit).with("offset", offset)
349350
.with("include_external", if (includeExternal == true) "audio" else null).toString()
350351
}
351352
}

src/commonMain/kotlin/com.adamratzman.spotify/endpoints/pub/TrackApi.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import com.adamratzman.spotify.models.serialization.toObject
1414
import com.adamratzman.spotify.utils.Market
1515
import com.adamratzman.spotify.utils.catch
1616
import com.adamratzman.spotify.utils.encodeUrl
17+
import com.adamratzman.spotify.utils.getSpotifyId
1718

1819
/**
1920
* Endpoints for retrieving information about one or more tracks from the Spotify catalog.
@@ -35,7 +36,7 @@ public class TrackApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
3536
get(
3637
endpointBuilder("/tracks/${PlayableUri(track).id.encodeUrl()}").with(
3738
"market",
38-
market?.name
39+
market?.getSpotifyId()
3940
).toString()
4041
).toObject(Track.serializer(), api, json)
4142
}
@@ -55,7 +56,7 @@ public class TrackApi(api: GenericSpotifyApi) : SpotifyEndpoint(api) {
5556
return bulkStatelessRequest(50, tracks.toList()) { chunk ->
5657
get(
5758
endpointBuilder("/tracks").with("ids", chunk.joinToString(",") { PlayableUri(it).id.encodeUrl() })
58-
.with("market", market?.name).toString()
59+
.with("market", market?.getSpotifyId()).toString()
5960
).toObject(TrackList.serializer(), api, json).tracks
6061
}.flatten()
6162
}

0 commit comments

Comments
 (0)