add simple playlist to playlist conversion test

Signed-off-by: Adam Ratzman <[email protected]>

Author: adamint

src/commonMain/kotlin/com.adamratzman.spotify/Builder.kt

@@ -7,6 +7,7 @@ import com.adamratzman.spotify.http.HttpRequestMethod
 import com.adamratzman.spotify.models.Token
 import com.adamratzman.spotify.models.serialization.nonstrictJson
 import com.adamratzman.spotify.models.serialization.toObject
+import io.ktor.client.features.ServerResponseException
 import kotlinx.coroutines.CancellationException
 import kotlinx.serialization.json.Json
 
@@ -639,7 +640,10 @@ public class SpotifyClientApiBuilder(
             } catch (e: CancellationException) {
                 throw e
             } catch (e: Exception) {
-                throw SpotifyException.AuthenticationException(
+                // BadRequestException -> ServerResponseException
+                if ((e.cause as? ServerResponseException)?.response?.status?.value in 500..599) {
+                    throw SpotifyException.BadRequestException("Spotify internal server error", e)
+                } else throw SpotifyException.AuthenticationException(
                     "Invalid credentials provided in the login process (clientId=$clientId, clientSecret=$clientSecret, authCode=${authorization.authorizationCode})",
                     e
                 )
@@ -675,7 +679,9 @@ public class SpotifyClientApiBuilder(
             } catch (e: CancellationException) {
                 throw e
             } catch (e: Exception) {
-                throw SpotifyException.AuthenticationException(
+                if ((e.cause as? ServerResponseException)?.response?.status?.value in 500..599) {
+                    throw SpotifyException.BadRequestException("Spotify internal server error", e)
+                } else throw SpotifyException.AuthenticationException(
                     "Invalid credentials provided in the login process (clientId=$clientId, clientSecret=$clientSecret, authCode=${authorization.authorizationCode})",
                     e
                 )
@@ -783,7 +789,9 @@ public class SpotifyAppApiBuilder(
             } catch (e: CancellationException) {
                 throw e
             } catch (e: Exception) {
-                throw SpotifyException.AuthenticationException(
+                if ((e.cause as? ServerResponseException)?.response?.status?.value in 500..599) {
+                    throw SpotifyException.BadRequestException("Spotify internal server error", e)
+                } else throw SpotifyException.AuthenticationException(
                     "Invalid credentials provided in the login process (clientId=$clientId, clientSecret=$clientSecret)",
                     e
                 )

src/commonMain/kotlin/com.adamratzman.spotify/models/serialization/SerializationUtils.kt

@@ -202,7 +202,6 @@ internal inline fun <reified T : Any> String.toNullablePagingObject(
 internal fun Map<String, JsonElement>.mapToJsonString() = JsonObject(this).toString()
 
 internal fun List<NeedsApi?>.instantiateAllNeedsApiObjects(api: GenericSpotifyApi) {
-    println("run on ${this.size} items")
     this.instantiateLateinitsIfPagingObjects(api)
     asSequence().filterNotNull().map { member -> member.getMembersThatNeedApiInstantiation() }.flatten()
         .distinct()

src/commonTest/kotlin/com.adamratzman/spotify/pub/PublicPlaylistsApiTest.kt

@@ -85,4 +85,13 @@ class PublicPlaylistsApiTest {
             assertFailsWithSuspend<SpotifyException.BadRequestException> { api.playlists.getPlaylistCovers("adskjfjkasdf") }
         }
     }
+
+    @Test
+    fun testConvertSimplePlaylistToPlaylist() {
+        runBlockingTest {
+            if (!testPrereq()) return@runBlockingTest
+            val simplePlaylist = api.playlists.getUserPlaylists("adamratzman1").first()!!
+            assertEquals(simplePlaylist.id, simplePlaylist.toFullPlaylist()?.id)
+        }
+    }
 }