Removed extraneous depends_on

adamrushuk · adamrushuk · commit c4095118ea4b · 2021-10-29T07:47:39.000+01:00
diff --git a/terraform/argocd_sso.tf b/terraform/argocd_sso.tf
@@ -40,6 +40,7 @@ resource "azuread_application" "argocd" {
       type = "Scope"
     }
 
+    # ? keeping for future reference
     # # application permissions, type=Role
     # resource_access {
     #   id   = azuread_service_principal.msgraph.app_role_ids["User.Read.All"]
@@ -80,7 +81,6 @@ resource "azuread_application_password" "argocd" {
   application_object_id = azuread_application.argocd.id
   display_name          = "argocd_secret"
   end_date              = "2099-01-01T01:02:03Z"
-  # depends_on            = [azuread_service_principal.argocd] # TODO: is this still required?
 }
 
 data "azurerm_client_config" "current" {}

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@ resource "azuread_application" "argocd" {`
`40`	`40`	`type = "Scope"`
`41`	`41`	`}`
`42`	`42`
	`43`	`+ # ? keeping for future reference`
`43`	`44`	`# # application permissions, type=Role`
`44`	`45`	`# resource_access {`
`45`	`46`	`# id = azuread_service_principal.msgraph.app_role_ids["User.Read.All"]`
`@@ -80,7 +81,6 @@ resource "azuread_application_password" "argocd" {`
`80`	`81`	`application_object_id = azuread_application.argocd.id`
`81`	`82`	`display_name = "argocd_secret"`
`82`	`83`	`end_date = "2099-01-01T01:02:03Z"`
`83`		`- # depends_on = [azuread_service_principal.argocd] # TODO: is this still required?`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`data "azurerm_client_config" "current" {}`