Skip to content

Commit 209ebcd

Browse files
authored
Merge pull request #191 from adamspd/189-when-client-enter-only-firstname-is-not-handled-well
Fixed ValueError for unpacking full name
2 parents 42b9df6 + 689b25b commit 209ebcd

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

appointment/tests/utils/test_db_helpers.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -982,6 +982,11 @@ def test_parse_name(self):
982982
self.assertEqual(first_name, 'Garshaw')
983983
self.assertEqual(last_name, 'of Belote')
984984

985+
name = "Teal'c"
986+
first_name, last_name = parse_name(name)
987+
self.assertEqual(first_name, "Teal'c")
988+
self.assertEqual(last_name, '')
989+
985990
def test_create_new_user_check_password(self):
986991
"""Test creating a new user with a password."""
987992
client_data = {'name': 'Harry Maybourne', 'email': '[email protected]'}

appointment/utils/db_helpers.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,10 @@ def generate_unique_username_from_email(email: str) -> str:
234234

235235

236236
def parse_name(name: str):
237-
return name.split(' ', 1)
237+
parts = name.split(' ', 1)
238+
if len(parts) == 1:
239+
parts.append('') # Add an empty string for the last name if not provided
240+
return parts[0], parts[1]
238241

239242

240243
def create_user_with_email(client_data: dict):

0 commit comments

Comments
 (0)