Added & optimized existing tests

Author: adamspd

appointment/settings.py

@@ -65,6 +65,6 @@ def check_q_cluster():
         for warning in missing_conf:
             logger.warning(warning)
         return False
-
+    print(f"Mising conf: {missing_conf}")
     # Both 'django_q' is installed and 'Q_CLUSTER' is configured
     return True

appointment/tests/test_availability_slot.py

@@ -1,3 +1,6 @@
+# test_availability_slot.py
+# Path: appointment/tests/test_availability_slot.py
+
 from datetime import date, time, timedelta
 
 from django.test import TestCase

appointment/tests/test_services.py

@@ -1,3 +1,6 @@
+# test_services.py
+# Path: appointment/tests/test_services.py
+
 import datetime
 import json
 from _decimal import Decimal

appointment/tests/test_settings.py

@@ -0,0 +1,45 @@
+# test_settings.py
+# Path: appointment/tests/test_settings.py
+
+from unittest.mock import patch
+
+from django.test import TestCase
+
+from appointment.settings import check_q_cluster
+
+
+class CheckQClusterTest(TestCase):
+    @patch('appointment.settings.settings')
+    @patch('appointment.settings.logger')
+    def test_check_q_cluster_with_django_q_missing(self, mock_logger, mock_settings):
+        # Simulate 'django_q' not being in INSTALLED_APPS
+        mock_settings.INSTALLED_APPS = []
+
+        # Call the function under test
+        result = check_q_cluster()
+
+        # Check the result
+        self.assertFalse(result)
+        # Verify logger was called with the expected warning about 'django_q' not being installed
+        mock_logger.warning.assert_called_with(
+            "Django Q is not in settings.INSTALLED_APPS. Please add it to the list.\n"
+            "Example: \n\n"
+            "INSTALLED_APPS = [\n"
+            "    ...\n"
+            "    'appointment',\n"
+            "    'django_q',\n"
+            "]\n")
+
+    @patch('appointment.settings.settings')
+    @patch('appointment.settings.logger')
+    def test_check_q_cluster_with_all_configurations_present(self, mock_logger, mock_settings):
+        # Simulate both 'django_q' being in INSTALLED_APPS and 'Q_CLUSTER' configuration present
+        mock_settings.INSTALLED_APPS = ['django_q']
+        mock_settings.Q_CLUSTER = {'name': 'DjangORM'}
+
+        # Call the function under test
+        result = check_q_cluster()
+
+        # Check the result and ensure no warnings are logged
+        self.assertTrue(result)
+        mock_logger.warning.assert_not_called()

appointment/tests/test_tasks.py

@@ -1,8 +1,12 @@
-from django.test import TestCase
+# test_tasks.py
+# Path: appointment/tests/test_tasks.py
+
 from unittest.mock import patch
+
+from django.utils.translation import gettext as _
+
 from appointment.tasks import send_email_reminder
 from appointment.tests.base.base_test import BaseTest
-from django.utils.translation import gettext as _
 
 
 class SendEmailReminderTest(BaseTest):

appointment/tests/test_utils.py

@@ -1,3 +1,6 @@
+# test_utils.py
+# Path: appointment/tests/test_utils.py
+
 import datetime
 import logging
 from unittest.mock import patch

appointment/tests/test_views.py

@@ -1,3 +1,6 @@
+# test_views.py
+# Path: appointment/tests/test_views.py
+
 import datetime
 import json
 from datetime import date, time, timedelta

appointment/tests/utils/test_date_time.py

@@ -1,12 +1,15 @@
+# test_date_time.py
+# Path: appointment/tests/utils/test_date_time.py
+
 import datetime
 from unittest.mock import Mock, patch
 
 from django.test import TestCase
 
 from appointment.settings import APP_TIME_ZONE
-from appointment.utils.date_time import convert_12_hour_time_to_24_hour_time, \
-    convert_str_to_date, convert_str_to_time, get_ar_end_time, time_difference, get_timezone, get_current_year, \
-    get_weekday_num, get_timestamp, convert_minutes_in_human_readable_format
+from appointment.utils.date_time import convert_12_hour_time_to_24_hour_time, convert_minutes_in_human_readable_format, \
+    convert_str_to_date, convert_str_to_time, get_ar_end_time, get_current_year, get_timestamp, get_timezone, \
+    get_weekday_num, time_difference
 
 
 class Convert12HourTo24HourTimeTests(TestCase):

appointment/tests/utils/test_db_helpers.py

@@ -2,13 +2,11 @@
 # Path: appointment/tests/utils/test_db_helpers.py
 
 import datetime
-from unittest.mock import patch, ANY
+from unittest.mock import patch
 
 from django.apps import apps
 from django.conf import settings
-from django.contrib.auth.hashers import make_password
 from django.core.cache import cache
-from django.core.exceptions import FieldDoesNotExist
 from django.test import TestCase
 from django.urls import reverse
 from django.utils import timezone
@@ -17,27 +15,22 @@
 from appointment.models import DayOff, PaymentInfo
 from appointment.tests.base.base_test import BaseTest
 from appointment.utils.date_time import get_current_year
-from appointment.utils.db_helpers import (calculate_slots, cancel_existing_reminder, check_day_off_for_staff,
-                                          create_and_save_appointment,
-                                          create_payment_info_and_get_url, exclude_booked_slots,
-                                          day_off_exists_for_date_range, get_all_staff_members,
-                                          get_all_appointments, Config, get_appointment_buffer_time,
-                                          get_appointment_by_id, get_appointment_finish_time,
-                                          get_appointment_lead_time, get_appointment_slot_duration,
-                                          get_appointments_for_date_and_time, get_config,
-                                          get_day_off_by_id, WorkingHours, get_non_working_days_for_staff,
-                                          get_staff_member_appointment_list,
-                                          get_weekday_num_from_date, get_staff_member_start_time,
-                                          get_staff_member_end_time, get_staff_member_buffer_time,
-                                          get_staff_member_slot_duration, get_user_by_email, get_user_model,
-                                          get_staff_member_from_user_id_or_logged_in,
-                                          get_staff_member_by_user_id, schedule_email_reminder,
-                                          update_appointment_reminder, working_hours_exist,
-                                          is_working_day,
-                                          get_working_hours_for_staff_and_day,
-                                          get_working_hours_by_id, get_website_name, get_times_from_config,
-                                          create_new_user, generate_unique_username_from_email, parse_name,
-                                          create_user_with_email, create_user_with_username)
+from appointment.utils.db_helpers import (Config, WorkingHours, calculate_slots, cancel_existing_reminder,
+                                          check_day_off_for_staff, create_and_save_appointment, create_new_user,
+                                          create_payment_info_and_get_url, day_off_exists_for_date_range,
+                                          exclude_booked_slots, generate_unique_username_from_email,
+                                          get_all_appointments, get_all_staff_members, get_appointment_buffer_time,
+                                          get_appointment_by_id, get_appointment_finish_time, get_appointment_lead_time,
+                                          get_appointment_slot_duration, get_appointments_for_date_and_time, get_config,
+                                          get_day_off_by_id, get_non_working_days_for_staff,
+                                          get_staff_member_appointment_list, get_staff_member_buffer_time,
+                                          get_staff_member_by_user_id, get_staff_member_end_time,
+                                          get_staff_member_from_user_id_or_logged_in, get_staff_member_slot_duration,
+                                          get_staff_member_start_time, get_times_from_config, get_user_by_email,
+                                          get_user_model, get_website_name, get_weekday_num_from_date,
+                                          get_working_hours_by_id, get_working_hours_for_staff_and_day, is_working_day,
+                                          parse_name, schedule_email_reminder, update_appointment_reminder,
+                                          working_hours_exist)
 
 
 class TestCalculateSlots(TestCase):

appointment/tests/utils/test_json_context.py

@@ -1,15 +1,13 @@
+# test_json_context.py
+# Path: appointment/tests/utils/test_json_context.py
+
 import json
 
 from django.test import RequestFactory
 
 from appointment.tests.base.base_test import BaseTest
-from appointment.utils.json_context import (
-    convert_appointment_to_json,
-    json_response,
-    get_generic_context,
-    get_generic_context_with_extra,
-    handle_unauthorized_response
-)
+from appointment.utils.json_context import (convert_appointment_to_json, get_generic_context,
+                                            get_generic_context_with_extra, handle_unauthorized_response, json_response)
 
 
 class JsonContextTests(BaseTest):