Remove vendored implementation of search_packages_info in favour of internal pip implementation

Author: adamtheturtle

.github/workflows/ci.yml

@@ -37,9 +37,7 @@ jobs:
 
       - name: "Run tests"
         run: |
-          # We currently require 99% test coverage and not 100% as this is the
-          # level that coverage was at when the CI restriction was introduced.
-          pytest -s -vvv --cov-fail-under 99 --cov=pip_check_reqs/ --cov=tests tests/ --cov-report=xml
+          pytest -s -vvv --cov-fail-under 100 --cov=pip_check_reqs/ --cov=tests tests/ --cov-report=xml
 
       - name: "Upload coverage to Codecov"
         uses: "codecov/codecov-action@v1"

pip_check_reqs/common.py

@@ -157,43 +157,3 @@ def f(candidate, ignore_cfg=ignore_cfg):
         return False
 
     return f
-
-
-def search_packages_info(query):
-    """
-    Gather details from installed distributions. Print distribution name,
-    version, location, and installed files. Installed files requires a
-    pip generated 'installed-files.txt' in the distributions '.egg-info'
-    directory.
-    """
-    installed = {}
-    for p in pkg_resources.working_set:
-        installed[canonicalize_name(p.project_name)] = p
-
-    query_names = [canonicalize_name(name) for name in query]
-
-    for dist in [installed[pkg] for pkg in query_names if pkg in installed]:
-        package = {
-            'name': dist.project_name,
-            'version': dist.version,
-            'location': dist.location,
-            'requires': [dep.project_name for dep in dist.requires()],
-        }
-        file_list = None
-        if isinstance(dist, pkg_resources.DistInfoDistribution):
-            # RECORDs should be part of .dist-info metadatas
-            if dist.has_metadata('RECORD'):
-                lines = dist.get_metadata_lines('RECORD')
-                paths = [line.split(',')[0] for line in lines]
-                paths = [os.path.join(dist.location, p) for p in paths]
-                file_list = [os.path.relpath(p, dist.location) for p in paths]
-        else:
-            # Otherwise use pip's log for .egg-info's
-            if dist.has_metadata('installed-files.txt'):
-                paths = dist.get_metadata_lines('installed-files.txt')
-                paths = [os.path.join(dist.egg_info, p) for p in paths]
-                file_list = [os.path.relpath(p, dist.location) for p in paths]
-
-        if file_list:
-            package['files'] = sorted(file_list)
-        yield package

pip_check_reqs/find_extra_reqs.py

@@ -5,9 +5,9 @@
 import sys
 
 from packaging.utils import canonicalize_name
+from pip._internal.commands.show import search_packages_info
 from pip._internal.utils.misc import get_installed_distributions
 from pip_check_reqs import common
-from pip_check_reqs.common import search_packages_info
 
 log = logging.getLogger(__name__)
 

pip_check_reqs/find_missing_reqs.py

@@ -5,12 +5,12 @@
 import sys
 
 from packaging.utils import canonicalize_name
+from pip._internal.commands.show import search_packages_info
 from pip._internal.download import PipSession
 from pip._internal.req.req_file import parse_requirements
 from pip._internal.utils.misc import get_installed_distributions
 
 from pip_check_reqs import common
-from pip_check_reqs.common import search_packages_info
 
 log = logging.getLogger(__name__)
 

tests/test_common.py

@@ -179,12 +179,3 @@ def ignore_reqs(req):
 
     reqs = common.find_required_modules(options)
     assert reqs == set(['foobar'])
-
-
-def test_search_packages_info():
-    # We know that 'packaging' will be installed because it is a requirement of
-    # this package.
-    installed_package = 'packaging'
-    query = ('packaging', )
-    [result] = [item for item in common.search_packages_info(query=query)]
-    assert result['name'] == installed_package