Skip to content

Commit 8c09f5e

Browse files
committed
Progress towards having a test for the requirement.name bug
1 parent 8fbd2c4 commit 8c09f5e

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

pip_check_reqs/find_missing_reqs.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ def find_missing_reqs(options):
6060
explicit = set()
6161
for requirement in parse_requirements('requirements.txt',
6262
session=PipSession()):
63-
log.debug('found requirement: %s', requirement.name)
63+
import pdb; pdb.set_trace()
64+
log.debug('found requirement: %s', requirement.requirement)
6465
explicit.add(canonicalize_name(requirement.name))
6566

6667
return [(name, used[name]) for name in used if name not in explicit]

tests/test_find_missing_reqs.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,13 @@ def test_find_missing_reqs(monkeypatch):
6363
monkeypatch.setattr(find_missing_reqs, 'search_packages_info',
6464
pretend.call_recorder(lambda x: packages_info))
6565

66-
FakeReq = collections.namedtuple('FakeReq', ['name'])
67-
requirements = [FakeReq('spam')]
66+
fake_requirements_file_contents = dedent(
67+
"""\
68+
spam
69+
"""
70+
)
71+
FakeReq = collections.namedtuple('FakeReq', [])
72+
requirements = [FakeReq()]
6873
monkeypatch.setattr(
6974
find_missing_reqs, 'parse_requirements',
7075
pretend.call_recorder(lambda a, session=None: requirements))

0 commit comments

Comments
 (0)