Fix --skip-incompatible flag

Why it is a bug
---------------

The flag also made the the code skip all other extra requirements. This
was due to a wrongfully added `else` clause, which should not be there:
because of it, the code that added requirements was triggered only `if
not options.skip_incompatible`, which is obviously wrong.

Why this patch fixes it
-----------------------

This patch makes the `explicit.add` code run even when the
`--skip-incompatible` flag is present.

With this patch, both of the branches that ignored the requirements
still work: the `options.ignore_reqs` still uses continue to bail on a
requirement, so does `options.skip_incompatible`.

Author: MrMino

CHANGELOG.rst

@@ -2,6 +2,10 @@
 Release History
 ---------------
 
+2.3.1
+
+- Fixed `--skip-incompatible` skipping other requirements too.
+
 2.3.0
 
 - Support pip >= 21.2.1

pip_check_reqs/__init__.py

@@ -1 +1 @@
-__version__ = '2.3.0'
+__version__ = '2.3.1'

pip_check_reqs/common.py

@@ -152,9 +152,8 @@ def find_required_modules(options, requirements_filename: str):
                           'marker): %s', requirement_string)
                 continue
 
-        else:
-            log.debug('found requirement: %s', requirement_name)
-            explicit.add(canonicalize_name(requirement_name))
+        log.debug('found requirement: %s', requirement_name)
+        explicit.add(canonicalize_name(requirement_name))
 
     return explicit
 

tests/test_common.py

@@ -195,7 +195,7 @@ def ignore_reqs(self, modname):
         options=options(),
         requirements_filename=str(fake_requirements_file),
     )
-    assert not reqs
+    assert reqs == {'ham', 'eggs'}
 
 
 def test_find_imported_modules_sets_encoding_to_utf8_when_reading(tmp_path):