fix program to generate exit code useful for testing

Author: r1chardj0n3s

CHANGELOG.rst

@@ -4,6 +4,7 @@ Release History
 1.1.2
 - corrected version of vendored search_packages_info() from pip
 - handle relative imports
+- fix program to generate exit code useful for testing
 
 1.1.1
 - fixed handling of import from __future__

pip_missing_reqs/find_missing_reqs.py

@@ -203,9 +203,8 @@ def find_missing_reqs(options):
             session=PipSession()):
         explicit.add(normalize_name(requirement.name))
 
-    for name in used:
-        if name not in explicit:
-            yield name, used[name]
+    return [(name, used[name]) for name in used
+        if name not in explicit]
 
 
 def ignorer(ignore_cfg):
@@ -238,7 +237,7 @@ def main():
 
     if not args:
         parser.error("no source files or directories specified")
-        sys.exit(-1)
+        sys.exit(2)
 
     options.ignore_files = ignorer(options.ignore_files)
     options.ignore_mods = ignorer(options.ignore_mods)
@@ -248,11 +247,17 @@ def main():
     logging.basicConfig(format='%(message)s')
     log.setLevel(logging.INFO if options.verbose else logging.WARN)
 
-    for name, uses in find_missing_reqs(options):
+    missing = find_missing_reqs(options)
+    for name, uses in missing:
         for use in uses:
             for filename, lineno in use.locations:
+                print(os.path.relpath(filename), lineno, name, use.modname)
                 log.warning('%s:%s dist=%s module=%s',
                     os.path.relpath(filename), lineno, name, use.modname)
 
+    if missing:
+        sys.exit(1)
+
+
 if __name__ == '__main__':  # pragma: no cover
     main()

pip_missing_reqs/test_find_missing_reqs.py

@@ -182,7 +182,7 @@ def test_find_missing_reqs(monkeypatch):
     assert result == [('shrub', [imported_modules['shrub']])]
 
 
-def test_main(monkeypatch, caplog):
+def test_main_failure(monkeypatch, caplog):
     class options:
         paths = ['dummy']
         verbose = True
@@ -209,7 +209,9 @@ def parse_args(self):
             [('location.py', 1)])])
     ])
 
-    find_missing_reqs.main()
+    with pytest.raises(SystemExit) as excinfo:
+        find_missing_reqs.main()
+        assert excinfo.value == 1
 
     assert caplog.records()[0].message == \
         'location.py:1 dist=missing module=missing'
@@ -232,8 +234,9 @@ def parse_args(self):
     monkeypatch.setattr(find_missing_reqs, 'ignorer',
         pretend.call_recorder(lambda a: None))
 
-    with pytest.raises(SystemExit):
+    with pytest.raises(SystemExit) as excinfo:
         find_missing_reqs.main()
+        assert excinfo.value == 2
 
     assert FakeOptParse.error.calls
     assert not find_missing_reqs.ignorer.calls