Skip to content

Commit d07feb7

Browse files
committed
Integrate change from Czaki and test for that change
1 parent 1fd8ae4 commit d07feb7

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

pip_check_reqs/find_missing_reqs.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,10 @@ def find_missing_reqs(options, requirements_filename):
6868
# We exclude the "except" from coverage so that on any pip version we
6969
# can report 100% coverage.
7070
except AttributeError: # pragma: no cover
71-
requirement_name = requirement.requirement
71+
from pip._internal.req.constructors import install_req_from_line
72+
requirement_name = install_req_from_line(
73+
requirement.requirement,
74+
).name
7275

7376
log.debug('found requirement: %s', requirement_name)
7477
explicit.add(canonicalize_name(requirement_name))

tests/test_find_missing_reqs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_find_missing_reqs(monkeypatch, tmp_path: Path):
6565
pretend.call_recorder(lambda x: packages_info))
6666

6767
fake_requirements_file = tmp_path / 'requirements.txt'
68-
fake_requirements_file.write_text('spam')
68+
fake_requirements_file.write_text('spam==1')
6969

7070
result = list(
7171
find_missing_reqs.find_missing_reqs(

0 commit comments

Comments
 (0)