Skip to content

Commit f0716ac

Browse files
Merge pull request #68 from MrMino/fix_skip_incompatible
Fix --skip-incompatible flag
2 parents 6b4dca7 + 9960d93 commit f0716ac

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Release History
44

55
2.3.1
66

7+
- Fixed `--skip-incompatible` skipping other requirements too.
78
- Support pip >= 21.3
89

910
2.3.0

pip_check_reqs/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '2.3.0'
1+
__version__ = '2.3.1'

pip_check_reqs/common.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,8 @@ def find_required_modules(options, requirements_filename: str):
191191
'marker): %s', requirement_string)
192192
continue
193193

194-
else:
195-
log.debug('found requirement: %s', requirement_name)
196-
explicit.add(canonicalize_name(requirement_name))
194+
log.debug('found requirement: %s', requirement_name)
195+
explicit.add(canonicalize_name(requirement_name))
197196

198197
return explicit
199198

tests/test_common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ def ignore_reqs(self, modname):
195195
options=options(),
196196
requirements_filename=str(fake_requirements_file),
197197
)
198-
assert not reqs
198+
assert reqs == {'ham', 'eggs'}
199199

200200

201201
def test_find_imported_modules_sets_encoding_to_utf8_when_reading(tmp_path):

0 commit comments

Comments
 (0)