Skip to content

Commit f2277bf

Browse files
Merge pull request #37 from r1chardj0n3s/separate-ci-runs
Run CI with the lowest and highest pip versions supported
2 parents 4fb67c5 + a60154c commit f2277bf

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ jobs:
1515

1616
strategy:
1717
matrix:
18+
# These versions match the minimum and maximum versions of pip in
19+
# requirements.txt
20+
pip-version: ['==10.0.1', '<= 19']
1821
python-version: [3.6, 3.7, 3.8]
1922

2023
steps:
@@ -26,7 +29,8 @@ jobs:
2629

2730
- name: "Install dependencies"
2831
run: |
29-
python -m pip install --upgrade --editable .[dev]
32+
pip install --upgrade --editable .[dev]
33+
pip install --upgrade 'pip ${{ matrix.pip-version }}'
3034
pip install flake8
3135
3236
- name: "Lint"

pip_check_reqs/find_extra_reqs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def find_extra_reqs(options):
2525
package['location'])
2626
for package_file in package.get('files', []) or []:
2727
path = os.path.realpath(
28-
os.path.join(package['location'],package_file),
28+
os.path.join(package['location'], package_file),
2929
)
3030
installed_files[path] = package['name']
3131
package_path = common.is_package_file(path)

pip_check_reqs/find_missing_reqs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def find_missing_reqs(options):
2828
package['location'])
2929
for package_file in package.get('files', []) or []:
3030
path = os.path.realpath(
31-
os.path.join(package['location'],package_file),
31+
os.path.join(package['location'], package_file),
3232
)
3333
installed_files[path] = package['name']
3434
package_path = common.is_package_file(path)

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
packaging
2+
# These versions are matched in the GitHub workflows CI.
23
pip >= 10.0.1, <= 19

0 commit comments

Comments
 (0)