Fix a bunch of ruff errors

Author: adamtheturtle

pip_check_reqs/common.py

@@ -1,4 +1,3 @@
-
 """Common functions."""
 
 from __future__ import annotations
@@ -52,15 +51,15 @@ def set_location(self, location: str) -> None:
         self._location = location
 
     # Ignore the name error as we are overriding the method.
-    def visit_Import(  # pylint: disable=invalid-name
+    def visit_Import(  # noqa: N802, pylint: disable=invalid-name
         self,
         node: ast.Import,
     ) -> None:
         for alias in node.names:
             self._add_module(alias.name, node.lineno)
 
     # Ignore the name error as we are overriding the method.
-    def visit_ImportFrom(  # pylint: disable=invalid-name
+    def visit_ImportFrom(  # noqa: N802, pylint: disable=invalid-name
         self,
         node: ast.ImportFrom,
     ) -> None:
@@ -145,7 +144,6 @@ def find_imported_modules(
                 continue
             log.debug("scanning: %s", os.path.relpath(filename))
             content = filename.read_text(encoding="utf-8")
-            # with open(filename, encoding="utf-8") as file_obj:
             vis.set_location(str(filename))
             vis.visit(ast.parse(content, str(filename)))
     return vis.finalise()
@@ -154,14 +152,16 @@ def find_imported_modules(
 def find_required_modules(
     *,
     ignore_requirements_function: Callable[
-        [str | ParsedRequirement], bool,
+        [str | ParsedRequirement],
+        bool,
     ],
     skip_incompatible: bool,
     requirements_filename: Path,
 ) -> set[NormalizedName]:
     explicit = set()
     for requirement in parse_requirements(
-        str(requirements_filename), session=PipSession(),
+        str(requirements_filename),
+        session=PipSession(),
     ):
         requirement_name = install_req_from_line(
             requirement.requirement,

pip_check_reqs/find_extra_reqs.py

@@ -31,7 +31,8 @@ def find_extra_reqs(
     ignore_files_function: Callable[[str], bool],
     ignore_modules_function: Callable[[str], bool],
     ignore_requirements_function: Callable[
-        [str | ParsedRequirement], bool,
+        [str | ParsedRequirement],
+        bool,
     ],
     skip_incompatible: bool,
 ) -> list[str]:
@@ -73,7 +74,9 @@ def find_extra_reqs(
             package_files.append(str(relative_item_location))
 
         log.debug(
-            "installed package: %s (at %s)", package_name, package_location,
+            "installed package: %s (at %s)",
+            package_name,
+            package_location,
         )
         for package_file in package_files:
             path = os.path.realpath(

pip_check_reqs/find_missing_reqs.py

@@ -68,7 +68,9 @@ def find_missing_reqs(
             package_files.append(str(relative_item_location))
 
         log.debug(
-            "installed package: %s (at %s)", package_name, package_location,
+            "installed package: %s (at %s)",
+            package_name,
+            package_location,
         )
         for package_file in package_files:
             path = os.path.realpath(

spelling_private_dict.txt

@@ -1 +1,3 @@
 pragma
+reqs
+

tests/test_common.py

@@ -34,7 +34,7 @@ def test_found_module() -> None:
     found_module = common.FoundModule("spam", "ham")
     assert found_module.modname == "spam"
     assert found_module.filename == str(Path("ham").resolve())
-    assert found_module.locations == []
+    assert not found_module.locations
 
 
 @pytest.mark.parametrize(
@@ -51,7 +51,7 @@ def test_found_module() -> None:
     ],
 )
 def test_import_visitor(stmt: str, result: list[str]) -> None:
-    vis = common._ImportVisitor(  # pylint: disable=protected-access
+    vis = common._ImportVisitor(  # noqa: SLF001,E501, pylint: disable=protected-access
         ignore_modules_function=common.ignorer(ignore_cfg=[]),
     )
     vis.set_location("spam.py")
@@ -188,6 +188,7 @@ def ignore_mods(module: str) -> bool:
     ],
 )
 def test_ignorer(
+    *,
     monkeypatch: pytest.MonkeyPatch,
     ignore_cfg: list[str],
     candidate: str,