fix logging level and formatting

Author: r1chardj0n3s

pip_missing_reqs/find_missing_reqs.py

@@ -36,12 +36,10 @@ def set_location(self, location):
         self.__location = location
 
     def visit_Import(self, node):
-        print('visit_Import', node)
         for alias in node.names:
             self.__addModule(alias.name, node.lineno)
 
     def visit_ImportFrom(self, node):
-        print('visit_ImportFrom', node)
         for alias in node.names:
             self.__addModule(node.module + '.' + alias.name, node.lineno)
 
@@ -191,8 +189,8 @@ def ignore_files(filename, ignore_files=options.ignore_files):
 
     options.paths = args or ['.']
 
-    logging.basicConfig(level=logging.INFO if options.verbose
-        else logging.WARN)
+    logging.basicConfig(format='%(message)s')
+    log.setLevel(logging.INFO if options.verbose else logging.WARN)
 
     for name, uses in find_missing_reqs(options):
         for use in uses:

pip_missing_reqs/test_find_missing_reqs.py

@@ -227,3 +227,34 @@ def parse_args(self):
 
     for fn, matched in file_candidates:
         assert options.ignore_files(fn) == matched
+
+
+@pytest.mark.parametrize(["verbose_cfg", "events", "result"], [
+    (False, [(logging.INFO, 'info'), (logging.WARN, 'warn')], ['warn']),
+    (True, [(logging.INFO, 'info'), (logging.WARN, 'warn')], ['info', 'warn']),
+])
+def test_logging_config(monkeypatch, caplog, verbose_cfg, events, result):
+    class options:
+        paths = ['dummy']
+        verbose = verbose_cfg
+        ignore_files = []
+        ignore_mods = []
+    options = options()
+
+    class FakeOptParse:
+        def add_option(*args, **kw):
+            pass
+
+        def parse_args(self):
+            return [options, 'ham.py']
+
+    monkeypatch.setattr(optparse, 'OptionParser', FakeOptParse)
+
+    monkeypatch.setattr(find_missing_reqs, 'find_missing_reqs', lambda x: [])
+    find_missing_reqs.main()
+
+    for event in events:
+        find_missing_reqs.log.log(*event)
+
+    messages = [r.message for r in caplog.records()]
+    assert messages == result