Fix: Correct inverted file size validation check

taylortom · claude · taylortom · commit e94ef2bb7b6c · 2026-02-20T14:54:43.000Z
The negation operator was applied to f.size instead of the comparison,
causing the size check to always evaluate as truthy. Files exceeding
maxFileSize were never rejected.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/lib/MiddlewareModule.js b/lib/MiddlewareModule.js
@@ -269,7 +269,7 @@ async function validateUploadedFiles (req, filesObj, options) {
         assetErrors.push(errors.UNEXPECTED_FILE_TYPES.setData({ expectedFileTypes: options.expectedFileTypes, invalidFiles: [f.originalFilename], mimetypes: [f.mimetype] }))
       }
     }
-    if (!f.size > options.maxFileSize) {
+    if (f.size > options.maxFileSize) {
       assetErrors.push(errors.FILE_EXCEEDS_MAX_SIZE.setData({ size: bytes(f.size), maxSize: bytes(options.maxFileSize) }))
     }
   }))

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ async function validateUploadedFiles (req, filesObj, options) {`
`269`	`269`	`assetErrors.push(errors.UNEXPECTED_FILE_TYPES.setData({ expectedFileTypes: options.expectedFileTypes, invalidFiles: [f.originalFilename], mimetypes: [f.mimetype] }))`
`270`	`270`	`}`
`271`	`271`	`}`
`272`		`- if (!f.size > options.maxFileSize) {`
	`272`	`+ if (f.size > options.maxFileSize) {`
`273`	`273`	`assetErrors.push(errors.FILE_EXCEEDS_MAX_SIZE.setData({ size: bytes(f.size), maxSize: bytes(options.maxFileSize) }))`
`274`	`274`	`}`
`275`	`275`	`}))`