Skip to content

Commit dc61029

Browse files
refactor(select): rename to SelectMultiple and SelectSingleNative
1 parent 7a32bb2 commit dc61029

File tree

4 files changed

+17
-15
lines changed

4 files changed

+17
-15
lines changed
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ import { classesGridCols3xl } from "~ui/static/container/classesGridCols"
1212
import { classArr } from "~ui/utils/classArr"
1313
import { classMerge } from "~ui/utils/classMerge"
1414
import type { SignalObject } from "~ui/utils/createSignalObject"
15-
import type { HasId } from "~ui/utils/HasId"
1615
import type { MayHaveChildren } from "~ui/utils/MayHaveChildren"
1716
import type { MayHaveClass } from "~ui/utils/MayHaveClass"
17+
import type { MayHaveId } from "~ui/utils/MayHaveId"
1818
import type { MayHaveInnerClass } from "~ui/utils/MayHaveInnerClass"
1919

2020
/**
2121
* https://github.com/radix-ui/primitives/blob/main/packages/react/checkbox/src/Checkbox.tsx
2222
*/
23-
export interface MultiSelectProps extends HasId, MayHaveClass, MayHaveInnerClass, MayHaveChildren {
23+
export interface SelectMultipleProps extends MayHaveId, MayHaveClass, MayHaveInnerClass, MayHaveChildren {
2424
buttonProps: CorvuPopoverProps
2525
textNoEntries?: string
2626
textAddEntry?: string
@@ -32,7 +32,7 @@ export interface MultiSelectProps extends HasId, MayHaveClass, MayHaveInnerClass
3232
listOptionClass?: string
3333
}
3434

35-
export function MultiSelect(p: MultiSelectProps) {
35+
export function SelectMultiple(p: SelectMultipleProps) {
3636
const buttonClass = classMerge(p.addEntryClass, p.buttonProps.class)
3737
const buttonProps = mergeProps(p.buttonProps, {
3838
icon: mdiPlus,
@@ -110,7 +110,7 @@ function SelectedValue(p: SelectedValueProps) {
110110
)
111111
}
112112

113-
interface OptionListProps extends HasId, MayHaveInnerClass {
113+
interface OptionListProps extends MayHaveId, MayHaveInnerClass {
114114
valueSignal: SignalObject<string[]>
115115
getOptions: Accessor<string[]>
116116
valueText?: (value: string) => string
@@ -147,7 +147,7 @@ function getInnerClass(optionAmount: number, innerClass?: string): string {
147147
return ""
148148
}
149149

150-
interface ListOptionProps extends HasId, MultiselectOptionState {
150+
interface ListOptionProps extends MayHaveId, MultiselectOptionState {
151151
index: number
152152
listOptionClass?: string
153153
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ import type { SignalObject } from "~ui/utils/createSignalObject"
99

1010
export type StringStringFn = (value: string) => string
1111

12-
export interface NativeSingleSelectProps extends MayHaveClass, MayHaveChildren {
12+
export interface SelectSingleNativeProps extends MayHaveClass, MayHaveChildren {
1313
valueSignal: SignalObject<string>
1414
getOptions: Accessor<string[]>
1515
valueText?: StringStringFn
1616
id?: string
1717
}
1818

19-
export function NativeSingleSelect(p: NativeSingleSelectProps) {
19+
export function SelectSingleNative(p: SelectSingleNativeProps) {
2020
return (
2121
<select
2222
id={p.id}
@@ -44,7 +44,7 @@ function onChange(
4444
currentTarget: HTMLSelectElement
4545
target: HTMLSelectElement
4646
},
47-
p: NativeSingleSelectProps,
47+
p: SelectSingleNativeProps,
4848
): void {
4949
p.valueSignal.set(e.currentTarget.value)
5050
}
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
1-
import { MultiSelect } from "~ui/input/select/MultiSelect"
1+
import { demoGetTextValue } from "@/demos/input/demoGetTextValue"
2+
import { SelectMultiple } from "~ui/input/select/SelectMultiple"
23
import { PageWrapper } from "~ui/static/page/PageWrapper"
34
import { createSignalObject } from "~ui/utils/createSignalObject"
45
import { arrCreate } from "~utils/arr/arrCreate"
56

67
const options100Strings = arrCreate<string>(100, (i) => "" + i)
78
const multiValueSignal = createSignalObject<string[]>([])
89

9-
export function DemoMultiSelect() {
10+
export function DemoSelectMultiple() {
1011
return (
1112
<PageWrapper>
12-
<MultiSelect
13+
<SelectMultiple
1314
id="DemoMultiSelect"
1415
valueSignal={multiValueSignal}
1516
getOptions={() => options100Strings}
1617
buttonProps={{}}
17-
valueText={(value) => "Option " + value}
18+
valueText={demoGetTextValue}
1819
/>
1920
</PageWrapper>
2021
)
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
1+
import { demoGetTextValue } from "@/demos/input/demoGetTextValue"
12
import { createMemo, type Accessor } from "solid-js"
2-
import { NativeSingleSelect } from "~ui/input/select/NativeSingleSelect"
3+
import { SelectSingleNative } from "~ui/input/select/SelectSingleNative"
34
import { PageWrapper } from "~ui/static/page/PageWrapper"
45
import { createSignalObject } from "~ui/utils/createSignalObject"
56
import { arrCreate } from "~utils/arr/arrCreate"
67

78
const options100 = arrCreate<string>(100, (i) => "" + i)
89
const singleValueSignal = createSignalObject<string>("")
910

10-
export function DemoNativeSingleSelect() {
11+
export function DemoSelectSingleNative() {
1112
const getOptions: Accessor<string[]> = createMemo(() => options100)
1213
const valueText = (value: string) => `Option ${value}`
1314

1415
return (
1516
<PageWrapper>
16-
<NativeSingleSelect valueSignal={singleValueSignal} getOptions={getOptions} valueText={valueText} />
17+
<SelectSingleNative valueSignal={singleValueSignal} getOptions={getOptions} valueText={demoGetTextValue} />
1718
</PageWrapper>
1819
)
1920
}

0 commit comments

Comments
 (0)