test(go): test storage write API in bulk ingest (#111)

Author: lidavidm

.pre-commit-config.yaml

@@ -14,7 +14,7 @@
 
 repos:
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: 36243b70e5ce219623c3503f5afba0f8c96fda55  # frozen: v0.14.7
+  rev: 0470f7c8a653e950f7cc5a653204ceb3fde4c02a  # frozen: v0.15.0
   hooks:
     - id: ruff-check
       name: "ruff check (isort)"
@@ -33,7 +33,7 @@ repos:
         )$
 
 - repo: https://github.com/golangci/golangci-lint
-  rev: e6ebea0145f385056bce15041d3244c0e5e15848  # frozen: v2.7.0
+  rev: e2e40021c9007020676c93680a36e3ab06c6cd33  # frozen: v2.8.0
   hooks:
   - id: golangci-lint
     entry: bash -c 'cd go && golangci-lint run --fix --timeout 5m'
@@ -56,6 +56,6 @@ repos:
   - id: trailing-whitespace
 
 - repo: https://github.com/adbc-drivers/dev
-  rev: 8ba235d79417939cf59e94ab85204731f7cbb9ba
+  rev: 30cd0fdecc0d03de3ca2a65acb4595505d3754ca
   hooks:
   - id: rat

.rat-apache

@@ -47,6 +47,7 @@ go/bigquery_database.go
 go/connection.go
 go/driver.go
 go/driver_test.go
+go/pkg/adbc.h
 go/pkg/driver.go
 go/pkg/utils.c
 go/pkg/utils.h

go/bulk_ingest.go

@@ -263,6 +263,9 @@ func writeFields(b *strings.Builder, fields []arrow.Field, skipName bool) error
 }
 
 func createTableStatement(options *driverbase.BulkIngestOptions, schema *arrow.Schema, ifTableExists driverbase.BulkIngestTableExistsBehavior, ifTableMissing driverbase.BulkIngestTableMissingBehavior) (string, error) {
+	// TODO: refactor this to take in a bigquery Client, and create the
+	// table by using DatasetInProject.Table.Create, passing in a
+	// bigquery.TableMetadata, instead of generating SQL
 	var b strings.Builder
 
 	switch ifTableExists {
@@ -271,6 +274,7 @@ func createTableStatement(options *driverbase.BulkIngestOptions, schema *arrow.S
 	case driverbase.BulkIngestTableExistsIgnore:
 		// Do nothing
 	case driverbase.BulkIngestTableExistsDrop:
+		// TODO: add CatalogName/SchemaName here
 		b.WriteString("DROP TABLE IF EXISTS ")
 		b.WriteString(quoteIdentifier(options.TableName))
 		b.WriteString("; ")