change trace method

Jade Wang · Jade Wang · commit 2d7d1aecaa6e · 2025-11-13T11:15:29.000-08:00
diff --git a/csharp/src/Reader/CloudFetch/BaseResultFetcher.cs b/csharp/src/Reader/CloudFetch/BaseResultFetcher.cs
@@ -27,6 +27,7 @@
 using System.Diagnostics;
 using System.Threading;
 using System.Threading.Tasks;
+using Apache.Arrow.Adbc.Tracing;
 
 namespace Apache.Arrow.Adbc.Drivers.Databricks.Reader.CloudFetch
 {
@@ -120,7 +121,9 @@ public async Task StopAsync()
             }
             catch (Exception ex)
             {
-                Trace.WriteLine($"Error stopping fetcher: {ex.Message}");
+                Activity.Current?.AddEvent("cloudfetch.fetcher_stop_error", [
+                    new("error_message", ex.Message)
+                ]);
             }
             finally
             {
@@ -210,7 +213,10 @@ private async Task FetchResultsWrapperAsync(CancellationToken cancellationToken)
             }
             catch (Exception ex)
             {
-                Trace.WriteLine($"Unhandled error in fetcher: {ex}");
+                Activity.Current?.AddEvent("cloudfetch.fetcher_unhandled_error", [
+                    new("error_message", ex.Message),
+                    new("error_type", ex.GetType().Name)
+                ]);
                 _error = ex;
                 _hasMoreResults = false;
                 _isCompleted = true;
diff --git a/csharp/src/Reader/CloudFetch/CloudFetchDownloader.cs b/csharp/src/Reader/CloudFetch/CloudFetchDownloader.cs
@@ -147,7 +147,10 @@ public async Task StopAsync()
             }
             catch (Exception ex)
             {
-                Trace.WriteLine($"Error stopping downloader: {ex}");
+                Activity.Current?.AddEvent("cloudfetch.downloader_stop_error", [
+                    new("error_message", ex.Message),
+                    new("error_type", ex.GetType().Name)
+                ]);
             }
             finally
             {
diff --git a/csharp/src/Reader/CloudFetch/CloudFetchReader.cs b/csharp/src/Reader/CloudFetch/CloudFetchReader.cs
@@ -157,15 +157,21 @@ public CloudFetchReader(
                             }
                             catch (Exception ex)
                             {
-                                Trace.WriteLine($"Error creating Arrow reader: {ex}");
+                                Activity.Current?.AddEvent("cloudfetch.arrow_reader_creation_error", [
+                                    new("error_message", ex.Message),
+                                    new("error_type", ex.GetType().Name)
+                                ]);
                                 this.currentDownloadResult.Dispose();
                                 this.currentDownloadResult = null;
                                 throw;
                             }
                         }
                         catch (Exception ex)
                         {
-                            Trace.WriteLine($"Error getting next downloaded file: {ex}");
+                            Activity.Current?.AddEvent("cloudfetch.get_next_file_error", [
+                                new("error_message", ex.Message),
+                                new("error_type", ex.GetType().Name)
+                            ]);
                             throw;
                         }
                     }
diff --git a/csharp/src/Reader/CloudFetch/CloudFetchResultFetcher.cs b/csharp/src/Reader/CloudFetch/CloudFetchResultFetcher.cs
@@ -192,7 +192,10 @@ protected override async Task FetchAllResultsAsync(CancellationToken cancellatio
                 }
                 catch (Exception ex)
                 {
-                    Trace.WriteLine($"Error fetching results: {ex}");
+                    Activity.Current?.AddEvent("cloudfetch.fetch_results_error", [
+                        new("error_message", ex.Message),
+                        new("error_type", ex.GetType().Name)
+                    ]);
                     _error = ex;
                     _hasMoreResults = false;
                     throw;
@@ -230,7 +233,10 @@ private async Task FetchNextResultBatchAsync(long? offset, CancellationToken can
             }
             catch (Exception ex)
             {
-                Trace.WriteLine($"Error fetching results from server: {ex}");
+                Activity.Current?.AddEvent("cloudfetch.fetch_from_server_error", [
+                    new("error_message", ex.Message),
+                    new("error_type", ex.GetType().Name)
+                ]);
                 _hasMoreResults = false;
                 throw;
             }

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`	`using System.Diagnostics;`
`28`	`28`	`using System.Threading;`
`29`	`29`	`using System.Threading.Tasks;`
	`30`	`+using Apache.Arrow.Adbc.Tracing;`
`30`	`31`
`31`	`32`	`namespace Apache.Arrow.Adbc.Drivers.Databricks.Reader.CloudFetch`
`32`	`33`	`{`
`@@ -120,7 +121,9 @@ public async Task StopAsync()`
`120`	`121`	`}`
`121`	`122`	`catch (Exception ex)`
`122`	`123`	`{`
`123`		`- Trace.WriteLine($"Error stopping fetcher: {ex.Message}");`
	`124`	`+ Activity.Current?.AddEvent("cloudfetch.fetcher_stop_error", [`
	`125`	`+ new("error_message", ex.Message)`
	`126`	`+ ]);`
`124`	`127`	`}`
`125`	`128`	`finally`
`126`	`129`	`{`
`@@ -210,7 +213,10 @@ private async Task FetchResultsWrapperAsync(CancellationToken cancellationToken)`
`210`	`213`	`}`
`211`	`214`	`catch (Exception ex)`
`212`	`215`	`{`
`213`		`- Trace.WriteLine($"Unhandled error in fetcher: {ex}");`
	`216`	`+ Activity.Current?.AddEvent("cloudfetch.fetcher_unhandled_error", [`
	`217`	`+ new("error_message", ex.Message),`
	`218`	`+ new("error_type", ex.GetType().Name)`
	`219`	`+ ]);`
`214`	`220`	`_error = ex;`
`215`	`221`	`_hasMoreResults = false;`
`216`	`222`	`_isCompleted = true;`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,10 @@ public async Task StopAsync()`
`147`	`147`	`}`
`148`	`148`	`catch (Exception ex)`
`149`	`149`	`{`
`150`		`- Trace.WriteLine($"Error stopping downloader: {ex}");`
	`150`	`+ Activity.Current?.AddEvent("cloudfetch.downloader_stop_error", [`
	`151`	`+ new("error_message", ex.Message),`
	`152`	`+ new("error_type", ex.GetType().Name)`
	`153`	`+ ]);`
`151`	`154`	`}`
`152`	`155`	`finally`
`153`	`156`	`{`
Original file line number	Diff line number	Diff line change
`@@ -157,15 +157,21 @@ public CloudFetchReader(`
`157`	`157`	`}`
`158`	`158`	`catch (Exception ex)`
`159`	`159`	`{`
`160`		`- Trace.WriteLine($"Error creating Arrow reader: {ex}");`
	`160`	`+ Activity.Current?.AddEvent("cloudfetch.arrow_reader_creation_error", [`
	`161`	`+ new("error_message", ex.Message),`
	`162`	`+ new("error_type", ex.GetType().Name)`
	`163`	`+ ]);`
`161`	`164`	`this.currentDownloadResult.Dispose();`
`162`	`165`	`this.currentDownloadResult = null;`
`163`	`166`	`throw;`
`164`	`167`	`}`
`165`	`168`	`}`
`166`	`169`	`catch (Exception ex)`
`167`	`170`	`{`
`168`		`- Trace.WriteLine($"Error getting next downloaded file: {ex}");`
	`171`	`+ Activity.Current?.AddEvent("cloudfetch.get_next_file_error", [`
	`172`	`+ new("error_message", ex.Message),`
	`173`	`+ new("error_type", ex.GetType().Name)`
	`174`	`+ ]);`
`169`	`175`	`throw;`
`170`	`176`	`}`
`171`	`177`	`}`
Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,10 @@ protected override async Task FetchAllResultsAsync(CancellationToken cancellatio`
`192`	`192`	`}`
`193`	`193`	`catch (Exception ex)`
`194`	`194`	`{`
`195`		`- Trace.WriteLine($"Error fetching results: {ex}");`
	`195`	`+ Activity.Current?.AddEvent("cloudfetch.fetch_results_error", [`
	`196`	`+ new("error_message", ex.Message),`
	`197`	`+ new("error_type", ex.GetType().Name)`
	`198`	`+ ]);`
`196`	`199`	`_error = ex;`
`197`	`200`	`_hasMoreResults = false;`
`198`	`201`	`throw;`
`@@ -230,7 +233,10 @@ private async Task FetchNextResultBatchAsync(long? offset, CancellationToken can`
`230`	`233`	`}`
`231`	`234`	`catch (Exception ex)`
`232`	`235`	`{`
`233`		`- Trace.WriteLine($"Error fetching results from server: {ex}");`
	`236`	`+ Activity.Current?.AddEvent("cloudfetch.fetch_from_server_error", [`
	`237`	`+ new("error_message", ex.Message),`
	`238`	`+ new("error_type", ex.GetType().Name)`
	`239`	`+ ]);`
`234`	`240`	`_hasMoreResults = false;`
`235`	`241`	`throw;`
`236`	`242`	`}`