adbc-drivers
diff --git a/‎csharp/doc/telemetry-sprint-plan.md‎
Lines changed: 17 additions & 0 deletions b/‎csharp/doc/telemetry-sprint-plan.md‎
Lines changed: 17 additions & 0 deletions
diff --git a/‎csharp/src/Telemetry/TagDefinitions/ConnectionOpenEvent.cs‎
Lines changed: 123 additions & 0 deletions b/‎csharp/src/Telemetry/TagDefinitions/ConnectionOpenEvent.cs‎
Lines changed: 123 additions & 0 deletions
diff --git a/‎csharp/src/Telemetry/TagDefinitions/ErrorEvent.cs‎
Lines changed: 102 additions & 0 deletions b/‎csharp/src/Telemetry/TagDefinitions/ErrorEvent.cs‎
Lines changed: 102 additions & 0 deletions
diff --git a/‎csharp/src/Telemetry/TagDefinitions/StatementExecutionEvent.cs‎
Lines changed: 133 additions & 0 deletions b/‎csharp/src/Telemetry/TagDefinitions/StatementExecutionEvent.cs‎
Lines changed: 133 additions & 0 deletions
@@ -92,11 +92,14 @@ Implement the core telemetry infrastructure including feature flag management, p
 #### WI-1.2: Tag Definition System
 **Description**: Create centralized tag definitions with export scope annotations.
 
+**Status**: ✅ **COMPLETED**
+
 **Location**: `csharp/src/Telemetry/TagDefinitions/`
 
 **Files**:
 - `TelemetryTag.cs` - Attribute and enums for export scope
 - `TelemetryTagRegistry.cs` - Central registry
+- `TelemetryEventType.cs` - Event type enum
 - `ConnectionOpenEvent.cs` - Connection event tags
 - `StatementExecutionEvent.cs` - Statement execution tags
 - `ErrorEvent.cs` - Error event tags
@@ -118,6 +121,20 @@ Implement the core telemetry infrastructure including feature flag management, p
 | Unit | `TelemetryTagRegistry_ShouldExportToDatabricks_SafeTag_ReturnsTrue` | EventType.StatementExecution, "statement.id" | true |
 | Unit | `ConnectionOpenEvent_GetDatabricksExportTags_ExcludesServerAddress` | N/A | Set does NOT contain "server.address" |
 
+**Implementation Notes**:
+- Used `HashSet<string>` instead of `IReadOnlySet<string>` for netstandard2.0 compatibility
+- All tag definitions use the `[TelemetryTag]` attribute for metadata
+- Sensitive tags (server.address, db.statement, error.stack_trace) are marked with `ExportScope = TagExportScope.ExportLocal`
+- Comprehensive test coverage with 31 unit tests in `TelemetryTagRegistryTests.cs`
+- Test file location: `csharp/test/Unit/Telemetry/TagDefinitions/TelemetryTagRegistryTests.cs`
+
+**Key Design Decisions**:
+1. **Flag-based enum**: `TagExportScope` uses `[Flags]` attribute to support combinations (ExportAll = ExportLocal | ExportDatabricks)
+2. **Privacy by design**: Sensitive tags are explicitly marked as local-only and excluded from `GetDatabricksExportTags()`
+3. **Static helper methods**: Each event class has `GetDatabricksExportTags()` to return the set of exportable tags
+4. **Registry pattern**: `TelemetryTagRegistry.ShouldExportToDatabricks()` provides centralized filtering logic
+5. **Unknown tags dropped**: Tags not in the registry are silently dropped for Databricks export (returns false)
+
 ---
 
 ### Phase 2: Per-Host Management
 
@@ -0,0 +1,123 @@
+/*
+* Copyright (c) 2025 ADBC Drivers Contributors
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+*     http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System.Collections.Generic;
+
+namespace AdbcDrivers.Databricks.Telemetry.TagDefinitions
+{
+    /// <summary>
+    /// Tag definitions for Connection.Open events.
+    /// </summary>
+    public static class ConnectionOpenEvent
+    {
+        /// <summary>
+        /// The event name for connection open operations.
+        /// </summary>
+        public const string EventName = "Connection.Open";
+
+        /// <summary>
+        /// Databricks workspace ID.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("workspace.id",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Databricks workspace ID",
+            Required = true)]
+        public const string WorkspaceId = "workspace.id";
+
+        /// <summary>
+        /// Connection session ID.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("session.id",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Connection session ID",
+            Required = true)]
+        public const string SessionId = "session.id";
+
+        /// <summary>
+        /// ADBC driver version.
+        /// Exported to all destinations.
+        /// </summary>
+        [TelemetryTag("driver.version",
+            ExportScope = TagExportScope.ExportAll,
+            Description = "ADBC driver version")]
+        public const string DriverVersion = "driver.version";
+
+        /// <summary>
+        /// Operating system information.
+        /// Exported to all destinations.
+        /// </summary>
+        [TelemetryTag("driver.os",
+            ExportScope = TagExportScope.ExportAll,
+            Description = "Operating system")]
+        public const string DriverOS = "driver.os";
+
+        /// <summary>
+        /// .NET runtime version.
+        /// Exported to all destinations.
+        /// </summary>
+        [TelemetryTag("driver.runtime",
+            ExportScope = TagExportScope.ExportAll,
+            Description = ".NET runtime version")]
+        public const string DriverRuntime = "driver.runtime";
+
+        /// <summary>
+        /// Whether CloudFetch is enabled.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("feature.cloudfetch",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "CloudFetch enabled")]
+        public const string FeatureCloudFetch = "feature.cloudfetch";
+
+        /// <summary>
+        /// Whether LZ4 compression is enabled.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("feature.lz4",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "LZ4 compression enabled")]
+        public const string FeatureLz4 = "feature.lz4";
+
+        /// <summary>
+        /// Workspace host address.
+        /// Only exported to local diagnostics (contains potentially sensitive data).
+        /// </summary>
+        [TelemetryTag("server.address",
+            ExportScope = TagExportScope.ExportLocal,
+            Description = "Workspace host (local diagnostics only)")]
+        public const string ServerAddress = "server.address";
+
+        /// <summary>
+        /// Gets all tags that should be exported to Databricks telemetry service.
+        /// </summary>
+        /// <returns>A set of tag names for Databricks export.</returns>
+        public static HashSet<string> GetDatabricksExportTags()
+        {
+            return new HashSet<string>
+            {
+                WorkspaceId,
+                SessionId,
+                DriverVersion,
+                DriverOS,
+                DriverRuntime,
+                FeatureCloudFetch,
+                FeatureLz4
+            };
+        }
+    }
+}
@@ -0,0 +1,102 @@
+/*
+* Copyright (c) 2025 ADBC Drivers Contributors
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+*     http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System.Collections.Generic;
+
+namespace AdbcDrivers.Databricks.Telemetry.TagDefinitions
+{
+    /// <summary>
+    /// Tag definitions for Error events.
+    /// </summary>
+    public static class ErrorEvent
+    {
+        /// <summary>
+        /// The event name for error events.
+        /// </summary>
+        public const string EventName = "Error";
+
+        /// <summary>
+        /// Error type or exception type name.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("error.type",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Error type or exception type",
+            Required = true)]
+        public const string ErrorType = "error.type";
+
+        /// <summary>
+        /// Error message (sanitized, no PII).
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("error.message",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Error message (sanitized)")]
+        public const string ErrorMessage = "error.message";
+
+        /// <summary>
+        /// HTTP status code if applicable.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("error.http_status",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "HTTP status code")]
+        public const string ErrorHttpStatus = "error.http_status";
+
+        /// <summary>
+        /// Statement ID associated with the error.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("statement.id",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Statement ID associated with error")]
+        public const string StatementId = "statement.id";
+
+        /// <summary>
+        /// Session ID associated with the error.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("session.id",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Session ID associated with error")]
+        public const string SessionId = "session.id";
+
+        /// <summary>
+        /// Full stack trace.
+        /// Only exported to local diagnostics (may contain sensitive paths).
+        /// </summary>
+        [TelemetryTag("error.stack_trace",
+            ExportScope = TagExportScope.ExportLocal,
+            Description = "Full stack trace (local diagnostics only)")]
+        public const string ErrorStackTrace = "error.stack_trace";
+
+        /// <summary>
+        /// Gets all tags that should be exported to Databricks telemetry service.
+        /// </summary>
+        /// <returns>A set of tag names for Databricks export.</returns>
+        public static HashSet<string> GetDatabricksExportTags()
+        {
+            return new HashSet<string>
+            {
+                ErrorType,
+                ErrorMessage,
+                ErrorHttpStatus,
+                StatementId,
+                SessionId
+            };
+        }
+    }
+}
@@ -0,0 +1,133 @@
+/*
+* Copyright (c) 2025 ADBC Drivers Contributors
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+*     http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System.Collections.Generic;
+
+namespace AdbcDrivers.Databricks.Telemetry.TagDefinitions
+{
+    /// <summary>
+    /// Tag definitions for Statement execution events.
+    /// </summary>
+    public static class StatementExecutionEvent
+    {
+        /// <summary>
+        /// The event name for statement execution operations.
+        /// </summary>
+        public const string EventName = "Statement.Execute";
+
+        /// <summary>
+        /// Statement execution ID.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("statement.id",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Statement execution ID",
+            Required = true)]
+        public const string StatementId = "statement.id";
+
+        /// <summary>
+        /// Connection session ID.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("session.id",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Connection session ID",
+            Required = true)]
+        public const string SessionId = "session.id";
+
+        /// <summary>
+        /// Result format (inline or cloudfetch).
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("result.format",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Result format: inline, cloudfetch")]
+        public const string ResultFormat = "result.format";
+
+        /// <summary>
+        /// Number of CloudFetch chunks.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("result.chunk_count",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Number of CloudFetch chunks")]
+        public const string ResultChunkCount = "result.chunk_count";
+
+        /// <summary>
+        /// Total bytes downloaded.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("result.bytes_downloaded",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Total bytes downloaded")]
+        public const string ResultBytesDownloaded = "result.bytes_downloaded";
+
+        /// <summary>
+        /// Whether compression is enabled for results.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("result.compression_enabled",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Compression enabled for results")]
+        public const string ResultCompressionEnabled = "result.compression_enabled";
+
+        /// <summary>
+        /// Number of status poll requests.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("poll.count",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Number of status poll requests")]
+        public const string PollCount = "poll.count";
+
+        /// <summary>
+        /// Total polling latency in milliseconds.
+        /// Exported to Databricks telemetry service.
+        /// </summary>
+        [TelemetryTag("poll.latency_ms",
+            ExportScope = TagExportScope.ExportDatabricks,
+            Description = "Total polling latency")]
+        public const string PollLatencyMs = "poll.latency_ms";
+
+        /// <summary>
+        /// SQL query text.
+        /// Only exported to local diagnostics (sensitive data).
+        /// </summary>
+        [TelemetryTag("db.statement",
+            ExportScope = TagExportScope.ExportLocal,
+            Description = "SQL query text (local diagnostics only)")]
+        public const string DbStatement = "db.statement";
+
+        /// <summary>
+        /// Gets all tags that should be exported to Databricks telemetry service.
+        /// </summary>
+        /// <returns>A set of tag names for Databricks export.</returns>
+        public static HashSet<string> GetDatabricksExportTags()
+        {
+            return new HashSet<string>
+            {
+                StatementId,
+                SessionId,
+                ResultFormat,
+                ResultChunkCount,
+                ResultBytesDownloaded,
+                ResultCompressionEnabled,
+                PollCount,
+                PollLatencyMs
+            };
+        }
+    }
+}