feat(go): override literal and select tests, implement DriverInfoPreparer, setup linters#107
Merged
lidavidm merged 5 commits intoadbc-drivers:mainfrom Jan 7, 2026
Conversation
Collaborator
Author
lidavidm
reviewed
Jan 3, 2026
lidavidm
pushed a commit
to adbc-drivers/validation
that referenced
this pull request
Jan 7, 2026
## What's Changed Use sqlglot to split statements based on the vendor. adbc-drivers/databricks#107 (comment)
lidavidm
approved these changes
Jan 7, 2026
Contributor
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Why do the docs fail to generate?
Collaborator
Author
|
it seems the gendoc is failing because it assumes test_get_info test has been run and the driver properties are recorded but since all the tests were skipped in the CI, the properties are not recorded, and it is erroring. Once we add the necessary env variables to the github secret, and tests start running it should resolve itself probably? https://github.com/adbc-drivers/validation/blob/main/adbc_drivers_validation/generate_documentation.py#L488 |
Contributor
|
Ah I thought the tests were running in CI, ok, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Other test failures are mostly from NotImplemented error. When we implement the new features, we will enable the corresponding tests.