Skip to content

feat(rust): (WONT MERGE, DESIGN DISSCUSSION)add metadata module structure and data types#210

Closed
vikrantpuppala wants to merge 1 commit intoadbc-drivers:mainfrom
vikrantpuppala:stack/metadata-module-structure-data-types
Closed

feat(rust): (WONT MERGE, DESIGN DISSCUSSION)add metadata module structure and data types#210
vikrantpuppala wants to merge 1 commit intoadbc-drivers:mainfrom
vikrantpuppala:stack/metadata-module-structure-data-types

Conversation

@vikrantpuppala
Copy link
Collaborator

@vikrantpuppala vikrantpuppala commented Feb 4, 2026

🥞 Stacked PR

Use this link to review incremental changes.


Create the foundation for ADBC Connection interface metadata methods:

  • Add metadata module with mod.rs and types.rs
  • Implement CatalogInfo, SchemaInfo, TableInfo structs for listing metadata
  • Implement ColumnInfo struct with full XDBC field support
  • Implement PrimaryKeyInfo and ForeignKeyInfo structs for constraints
  • Add comprehensive unit tests for struct instantiation and cloning

This establishes the data structures needed for get_objects(),
get_table_schema(), and other metadata query operations.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

What's Changed

Please fill in a description of the changes here.

This contains breaking changes.

Closes #NNN.

Create the foundation for ADBC Connection interface metadata methods:
- Add metadata module with mod.rs and types.rs
- Implement CatalogInfo, SchemaInfo, TableInfo structs for listing metadata
- Implement ColumnInfo struct with full XDBC field support
- Implement PrimaryKeyInfo and ForeignKeyInfo structs for constraints
- Add comprehensive unit tests for struct instantiation and cloning

This establishes the data structures needed for get_objects(),
get_table_schema(), and other metadata query operations.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@lidavidm
Copy link
Contributor

lidavidm commented Feb 4, 2026

Can we have Claude at least ensure pre-commit passes? cargo fmt also needs to be added to pre-commit. Also we should set up some CI to build the Rust code as well. I can enable the pregenerated workflows that other drivers use.

@@ -0,0 +1,969 @@
# Connection Interface Metadata Implementation Design
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this PR stack is based on this design. I think we need consider the design/implementing sequence of the driver. it should be

  1. basic connection and statement execution design and implementation (since metadata operation depend on this).
  2. metadata operation implementation
  3. cloudfetch implemenmtation
  4. auth related.
  5. client telemetry.

@jadewang-db jadewang-db marked this pull request as draft February 4, 2026 19:40
@jadewang-db
Copy link
Collaborator

Can we have Claude at least ensure pre-commit passes? cargo fmt also needs to be added to pre-commit. Also we should set up some CI to build the Rust code as well. I can enable the pregenerated workflows that other drivers use.

yes, we will, @lidavidm as I replied in the other comment, we are still in design discussion, the code generated here just to validate the design for now, no intend to merge of this.

@jadewang-db jadewang-db changed the title feat(rust): add metadata module structure and data types feat(rust): (WONT MERGE, DESIGN DISSCUSSIONH)add metadata module structure and data types Feb 4, 2026
@jadewang-db jadewang-db changed the title feat(rust): (WONT MERGE, DESIGN DISSCUSSIONH)add metadata module structure and data types feat(rust): (WONT MERGE, DESIGN DISSCUSSION)add metadata module structure and data types Feb 4, 2026
@vikrantpuppala vikrantpuppala deleted the stack/metadata-module-structure-data-types branch February 9, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants