fix(ci): enable auto-approve for infrastructure-only PRs by eric-wang-1990 · Pull Request #222 · adbc-drivers/databricks

eric-wang-1990 · 2026-02-05T17:46:58Z

Problem

The integration test workflow had a chicken-and-egg problem:

Branch protection requires "Integration Tests" check to pass
The workflow had auto-approve logic for infrastructure-only changes
BUT the auto-approve only worked for merge queue, not for PRs
So infrastructure-only PRs still needed manual integration-test labels

This was demonstrated by PR #209 - a PR that only removed test-infrastructure/ and .github/workflows/proxy-tests.yml still needed a manual label to create the required check.

Solution

Modified the auto-approve-no-relevant-changes job to work for both PR and merge queue events:

Changes

Unified path checking (check-paths job):
- Now runs for both pull_request and merge_group events
- Renamed from check-merge-queue-paths for clarity
- Added more driver paths: go/, rust/src/, rust/examples/
Auto-approve for PRs (auto-approve-no-relevant-changes):
- Extended condition to handle both event types
- Uses dynamic SHA detection based on event type
- Adds helpful comment on PRs explaining why tests were skipped
Updated triggers:
- Added opened event so checks run when PR is first created

Behavior

Before:

PR with only infrastructure changes → blocked → need manual label → tests skip anyway

After:

PR with only infrastructure changes → auto-approved immediately → no manual label needed
PR with driver code changes → need manual label (security) → tests run

Paths that trigger integration tests

.github/workflows/trigger-integration-tests.yml
ci/scripts/
csharp/src/ & csharp/test/
go/
rust/src/ & rust/examples/

Changes to other paths (docs, configs, removed test-infrastructure, etc.) automatically get approved.

Testing

This PR itself modifies only .github/workflows/trigger-integration-tests.yml, so it should auto-approve with the new logic! 🎯

🤖 Generated with Claude Code

Modifies the integration test workflow to automatically approve PRs that only change infrastructure/documentation files, eliminating the need for manual `integration-test` labels on such PRs. ## Changes 1. **Unified path checking** (`check-paths` job): - Now runs for both `pull_request` and `merge_group` events - Detects whether driver code was changed - Added more driver paths: `go/`, `rust/src/`, `rust/examples/` 2. **Auto-approve for PRs** (`auto-approve-no-relevant-changes` job): - Extended to work for both PR and merge queue events - Automatically creates passing "Integration Tests" check when only infrastructure files change - Adds explanatory comment on PRs for visibility 3. **Updated triggers**: - Added `opened` event so auto-approve runs when PR is first created ## Behavior **Before**: Infrastructure-only PRs (like removing test-infrastructure) required manual `integration-test` label to create the required check, even though tests should be skipped. **After**: Infrastructure-only PRs automatically get a passing "Integration Tests" check without manual intervention. Tests only run when driver code changes. ## Paths that trigger tests - `.github/workflows/trigger-integration-tests.yml` - `ci/scripts/` - `csharp/src/` & `csharp/test/` - `go/` - `rust/src/` & `rust/examples/` Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

eric-wang-1990 · 2026-02-05T18:07:31Z

Addressed review feedback:

✅ Removed go/, rust/src/, and rust/examples/ from the paths list - now only tracking C# driver paths (csharp/src/, csharp/test/)
✅ Simplified the PR comment - removed the detailed path listing

Changes made per your review comments. This workflow is specifically for the Databricks ADBC C# driver.

eric-wang-1990 · 2026-02-05T18:05:17Z

.github/workflows/trigger-integration-tests.yml

+            "go/"
+            "rust/src/"
+            "rust/examples/"


Remove these 3

eric-wang-1990 · 2026-02-05T18:05:33Z

.github/workflows/trigger-integration-tests.yml

+                      '- `go/`\n' +
+                      '- `rust/src/`\n' +
+                      '- `rust/examples/`\n\n' +


remove these

eric-wang-1990 · 2026-02-05T18:05:57Z

.github/workflows/trigger-integration-tests.yml

+                      '- `go/`\n' +
+                      '- `rust/src/`\n' +
+                      '- `rust/examples/`\n\n' +
+                      'Your changes only affect infrastructure/documentation, so tests are skipped.'


Your changes do not affect Databricks ADBC csharp driver

- Remove go/, rust/src/, rust/examples/ from paths list (C# driver only) - Simplify auto-approve PR comment (remove detailed path listing) Per review comments: This workflow is specifically for the Databricks ADBC C# driver. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

eric-wang-1990 · 2026-02-05T18:08:35Z

Changes have been committed and pushed. Please re-review when you have a chance. 🙏

Copilot

Pull request overview

This PR aims to fix a chicken-and-egg problem where infrastructure-only PRs were blocked waiting for the "Integration Tests" check, even though they would be auto-approved. The solution extends the auto-approve logic from merge queue events to also work for pull request events.

Changes:

Added opened event trigger so checks run when a PR is first created
Renamed check-merge-queue-paths to check-paths and extended it to run for both PR and merge_group events
Modified auto-approve-no-relevant-changes to work for both event types with dynamic SHA detection
Added PR comment functionality to explain why tests were skipped for infrastructure-only changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T18:13:34Z

.github/workflows/trigger-integration-tests.yml

            ".github/workflows/trigger-integration-tests.yml"
            "ci/scripts/"
            "csharp/src/"
            "csharp/test/"


The PR description states that "go/" and "rust/src/" and "rust/examples/" were added to the paths that trigger integration tests, but the PATHS array only includes ".github/workflows/trigger-integration-tests.yml", "ci/scripts/", "csharp/src/", and "csharp/test/".

The go/ and rust/ directories exist in the repository and contain driver code that should trigger integration tests. These paths need to be added to the PATHS array to match the documented behavior and ensure that changes to Go and Rust driver code trigger integration tests appropriately.

Suggested change

"csharp/test/"

"csharp/test/"

"go/"

"rust/src/"

"rust/examples/"

Copilot · 2026-02-05T18:13:35Z

.github/workflows/trigger-integration-tests.yml

+            // Add a comment on PR for visibility
+            if (isPR) {
+              await github.rest.issues.createComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: context.issue.number,
+                body: '✅ **Integration tests auto-approved**\n\n' +
+                      'No driver code changes detected. Your changes only affect infrastructure/documentation, so tests are skipped.'
+              });


The auto-approve comment on line 345-351 could be created multiple times if the workflow is re-run for the same PR. This could spam the PR with duplicate "Integration tests auto-approved" comments.

Consider adding logic to check if a comment with this message already exists before creating a new one. You can search for existing comments and either skip creation or update the existing comment instead of creating duplicates.

Suggested change

// Add a comment on PR for visibility

if (isPR) {

await github.rest.issues.createComment({

owner: context.repo.owner,

repo: context.repo.repo,

issue_number: context.issue.number,

body: '✅ **Integration tests auto-approved**\n\n' +

'No driver code changes detected. Your changes only affect infrastructure/documentation, so tests are skipped.'

});

// Add a comment on PR for visibility (avoid duplicates)

if (isPR) {

const commentBody =

'✅ **Integration tests auto-approved**\n\n' +

'No driver code changes detected. Your changes only affect infrastructure/documentation, so tests are skipped.';

// Check if an identical comment already exists to avoid spamming the PR

const { data: existingComments } = await github.rest.issues.listComments({

owner: context.repo.owner,

repo: context.repo.repo,

issue_number: context.issue.number,

per_page: 100,

});

const alreadyCommented = existingComments.some(

(comment) => comment.body === commentBody

);

if (!alreadyCommented) {

await github.rest.issues.createComment({

owner: context.repo.owner,

repo: context.repo.repo,

issue_number: context.issue.number,

body: commentBody,

});

}

Copilot · 2026-02-05T18:13:35Z

.github/workflows/trigger-integration-tests.yml

          PATHS=(
            ".github/workflows/trigger-integration-tests.yml"
            "ci/scripts/"
            "csharp/src/"
            "csharp/test/"
          )


The PR description claims "Added more driver paths: go/, rust/src/, rust/examples/" in the "Unified path checking" changes section, but these paths are not actually added to the PATHS array in the code. This is a significant discrepancy between the PR description and the actual implementation.

Either the paths need to be added to match the description, or the description needs to be updated to reflect that these paths were not added in this PR.

eric-wang-1990 commented Feb 5, 2026

View reviewed changes

eric-wang-1990 requested review from Copilot and jadewang-db February 5, 2026 18:10

Copilot started reviewing on behalf of eric-wang-1990 February 5, 2026 18:11 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): enable auto-approve for infrastructure-only PRs#222

fix(ci): enable auto-approve for infrastructure-only PRs#222
eric-wang-1990 wants to merge 2 commits intomainfrom
fix/auto-approve-pr-infrastructure-changes

eric-wang-1990 commented Feb 5, 2026

Uh oh!

eric-wang-1990 commented Feb 5, 2026

Uh oh!

eric-wang-1990 Feb 5, 2026

Uh oh!

eric-wang-1990 Feb 5, 2026

Uh oh!

eric-wang-1990 Feb 5, 2026

Uh oh!

eric-wang-1990 commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eric-wang-1990 commented Feb 5, 2026

Problem

Solution

Changes

Behavior

Paths that trigger integration tests

Testing

Uh oh!

eric-wang-1990 commented Feb 5, 2026

Uh oh!

eric-wang-1990 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

eric-wang-1990 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

eric-wang-1990 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

eric-wang-1990 commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants