ci(ci): trigger REST integration tests when SEA path is touched [PECO-2945]#315
ci(ci): trigger REST integration tests when SEA path is touched [PECO-2945]#315eric-wang-1990 merged 6 commits intomainfrom
Conversation
When csharp/src/StatementExecution/ files change, dispatch an additional adbc-csharp-pr-test event to databricks-driver-test with databricks_protocol=rest so the SEA/REST test suite runs alongside the default Thrift tests. Applies to both PR (label-triggered) and merge queue workflows. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The internal repo reads github.event.client_payload.extra_parameters as a JSON object and injects it as extraParameters in the test config. Use that field instead of the incorrect databricks_protocol top-level field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eric-wang-1990
had a problem deploying
to
azure-prod
GitHub Actions
Error
eric-wang-1990
added
the
integration-test
|
🚀 Integration tests triggered! View workflow run |
|
The cloudFetch tests should be triggered for SEA and thrift since they share the same path. |
eric-wang-1990
added
integration-test
|
🚀 Integration tests triggered! View workflow run |
We should start small, running both tests takes super long time, I would rather just run SEA with minimum time for now and update later |
eric-wang-1990
changed the title
eric-wang-1990
had a problem deploying
to
azure-prod
GitHub Actions
Error
github-actions
bot
removed
the
integration-test
|
🔒 Integration test approval reset New commits were pushed to this PR. The A maintainer must re-review the changes and re-add the label to trigger tests again. Why is this necessary?
Latest commit: 5a256a0 |
eric-wang-1990
added
the
integration-test
|
🚀 Integration tests triggered! View workflow run |
…xt parsing (PECO-2945)
GitHub Actions drops object keys containing dots when converting webhook
payloads to expression context. Sending {"adbc.databricks.protocol":"rest"}
as a JSON object caused the key to be stripped, resulting in {}.
The internal workflow's extra_parameters is a string-typed input, so send
it as a pre-encoded JSON string "{\"adbc.databricks.protocol\": \"rest\"}"
to match the expected format.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eric-wang-1990
had a problem deploying
to
azure-prod
GitHub Actions
Error
github-actions
bot
removed
the
integration-test
|
🔒 Integration test approval reset New commits were pushed to this PR. The A maintainer must re-review the changes and re-add the label to trigger tests again. Why is this necessary?
Latest commit: f52117b |
msrathore-db
left a comment
msrathore-db
left a comment
There was a problem hiding this comment.
LGTM. We can extend later to run SEA tests if cloudFetch path is changed
eric-wang-1990
added
the
integration-test
|
🚀 Integration tests triggered! View workflow run |
eric-wang-1990
had a problem deploying
to
azure-prod
GitHub Actions
Failure
github-actions
bot
removed
the
integration-test
|
🔒 Integration test approval reset New commits were pushed to this PR. The A maintainer must re-review the changes and re-add the label to trigger tests again. Why is this necessary?
Latest commit: ef94293 |
2 participants
Detect changes under csharp/src/StatementExecution/ and dispatch a second adbc-csharp-pr-test event with databricks_protocol=rest. Applies to both PR-label and merge queue. Thrift tests unaffected. Closes PECO-2945