test(go): create basic validation scaffold#99
Conversation
This reverts commit 9561d74.
This can be a regex but this should work too
|
There was an issue my DriverQuirks config which I fixed in 6ace295. @lidavidm can we merge this after you review and @Mandukhai-Alimaa can continue from there? |
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
@Mandukhai-Alimaa I'm going to merge, but please note these things to fix
There was a problem hiding this comment.
Why can't we just hardcode the driver name? (We can let Mandy fix this later.)
| markers = | ||
| feature: test for a driver-specific feature |
There was a problem hiding this comment.
| markers = | |
| feature: test for a driver-specific feature | |
| markers = | |
| feature: test for a driver-specific feature | |
| ignore:record_property is incompatible with junit_family:pytest.PytestWarning |
There was a problem hiding this comment.
(Where is this being copied from?)
There was a problem hiding this comment.
Probably mysql. I think trino is like this too. Do both need updating?
There was a problem hiding this comment.
Yeah, we should be treating warnings as errors.
Also I just noticed I did this wrong, it should be
| markers = | |
| feature: test for a driver-specific feature | |
| markers = | |
| feature: test for a driver-specific feature | |
| filterwarnings = | |
| error | |
| ignore:record_property is incompatible with junit_family:pytest.PytestWarning |
There was a problem hiding this comment.
I'll PRs here and elsewhere in a sec.
There was a problem hiding this comment.
| vendor_version = "v1.9.0" | ||
| short_version = "v1.9.0" |
There was a problem hiding this comment.
It seems this is the driver version and not the vendor version; that needs to be fixed
| # I copied in the members of DriverFeatures here and set them all to False | ||
| # or None. TODO: Disable/enable what should be enabled/disabled. | ||
| features = model.DriverFeatures( | ||
| connection_get_table_schema = False, |
There was a problem hiding this comment.
We need to set up the Python linter as with other repos
2 participants
What's Changed
Creates a basic validation suite scaffold for the Go driver.
Closes #96