diff --git a/csharp/src/Reader/CloudFetch/CloudFetchConfiguration.cs b/csharp/src/Reader/CloudFetch/CloudFetchConfiguration.cs index 3590d5fc..5de62864 100644 --- a/csharp/src/Reader/CloudFetch/CloudFetchConfiguration.cs +++ b/csharp/src/Reader/CloudFetch/CloudFetchConfiguration.cs @@ -31,7 +31,7 @@ internal sealed class CloudFetchConfiguration // Default values internal const int DefaultParallelDownloads = 3; internal const int DefaultPrefetchCount = 2; - internal const int DefaultMemoryBufferSizeMB = 100; + internal const int DefaultMemoryBufferSizeMB = 200; internal const int DefaultTimeoutMinutes = 5; internal const int DefaultMaxRetries = 3; internal const int DefaultRetryDelayMs = 500; diff --git a/csharp/src/Reader/CloudFetch/CloudFetchMemoryBufferManager.cs b/csharp/src/Reader/CloudFetch/CloudFetchMemoryBufferManager.cs index c4e976d4..b6acf841 100644 --- a/csharp/src/Reader/CloudFetch/CloudFetchMemoryBufferManager.cs +++ b/csharp/src/Reader/CloudFetch/CloudFetchMemoryBufferManager.cs @@ -39,7 +39,6 @@ namespace AdbcDrivers.Databricks.Reader.CloudFetch /// internal sealed class CloudFetchMemoryBufferManager : ICloudFetchMemoryBufferManager { - private const int DefaultMemoryBufferSizeMB = 200; private readonly long _maxMemory; private long _usedMemory; private readonly SemaphoreSlim _memorySemaphore; @@ -48,16 +47,15 @@ internal sealed class CloudFetchMemoryBufferManager : ICloudFetchMemoryBufferMan /// Initializes a new instance of the class. /// /// The maximum memory allowed for buffering in megabytes. - public CloudFetchMemoryBufferManager(int? maxMemoryMB = null) + public CloudFetchMemoryBufferManager(int maxMemoryMB = CloudFetchConfiguration.DefaultMemoryBufferSizeMB) { - int memoryMB = maxMemoryMB ?? DefaultMemoryBufferSizeMB; - if (memoryMB <= 0) + if (maxMemoryMB <= 0) { throw new ArgumentOutOfRangeException(nameof(maxMemoryMB), "Memory buffer size must be positive."); } // Convert MB to bytes - _maxMemory = memoryMB * 1024L * 1024L; + _maxMemory = maxMemoryMB * 1024L * 1024L; _usedMemory = 0; _memorySemaphore = new SemaphoreSlim(1, 1); } diff --git a/csharp/test/Unit/Reader/CloudFetch/CloudFetchMemoryBufferManagerTests.cs b/csharp/test/Unit/Reader/CloudFetch/CloudFetchMemoryBufferManagerTests.cs index 45f22c07..5ea6f9e5 100644 --- a/csharp/test/Unit/Reader/CloudFetch/CloudFetchMemoryBufferManagerTests.cs +++ b/csharp/test/Unit/Reader/CloudFetch/CloudFetchMemoryBufferManagerTests.cs @@ -28,7 +28,7 @@ public class CloudFetchMemoryBufferManagerTests public void Constructor_DefaultMaxMemory_Is200MB() { var manager = new CloudFetchMemoryBufferManager(); - Assert.Equal(200 * 1024L * 1024L, manager.MaxMemory); + Assert.Equal(CloudFetchConfiguration.DefaultMemoryBufferSizeMB * 1024L * 1024L, manager.MaxMemory); Assert.Equal(0, manager.UsedMemory); }