fix(adbc_drivers_dev/rat): handle binary files more gracefully #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoeba
force-pushed
the
fix/unicode-error
branch
from
0d3d976 to
8c9e0a9
Compare
amoeba
changed the title
Contributor
Author
|
@lidavidm I think there might be a few ways to go about this so I'm open to suggestions here. |
lidavidm
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Makes the RAT pre-commit command mores resilient when it encounters binary files. Without this change, pre-commit just fails with a cryptic UnicdoeDecodeError without any context for which file failed. Handling rat-excludes happens below this line so excluding any files you suspect may be the cause doesn't help.