Skip to content

Commit 33e73e0

Browse files
skovhusclaude
andauthored
Fix WebkitAppearance to accept all valid appearance values (facebook#1496)
WebkitAppearance was restricted to only 'textfield' while the standard appearance property accepts 'auto', 'none', and 'textfield'. Reuse the existing appearance rule so the vendor-prefixed variant allows the same values. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent bfb7f32 commit 33e73e0

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,13 @@ eslintTester.run('stylex-valid-styles', rule.default, {
392392
paddingInlineEnd: Math.round(x / 2),
393393
},
394394
})`,
395+
// test for WebkitAppearance with 'none'
396+
`import * as stylex from '@stylexjs/stylex';
397+
stylex.create({
398+
default: {
399+
'WebkitAppearance': 'none',
400+
},
401+
})`,
395402
// test for Search
396403
`import * as stylex from '@stylexjs/stylex';
397404
stylex.create({

packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1491,7 +1491,7 @@ const maskImage: RuleCheck = maskReference;
14911491
const SupportedVendorSpecificCSSProperties = {
14921492
MozOsxFontSmoothing: makeLiteralRule('grayscale') as RuleCheck,
14931493
WebkitFontSmoothing: makeLiteralRule('antialiased') as RuleCheck,
1494-
WebkitAppearance: makeLiteralRule('textfield') as RuleCheck,
1494+
WebkitAppearance: appearance,
14951495
WebkitTapHighlightColor: color,
14961496
WebkitOverflowScrolling: makeLiteralRule('touch') as RuleCheck,
14971497

0 commit comments

Comments
 (0)