Skip to content

Add more validation for "generate timesheet" #29

@gianklug

Description

@gianklug
              r.get("review") === data.review && 
              r.get("notBillable") === data.notBillable && 
              !r.get("verfiedBy") && 
              !r.get("isDeleted")

ig we can add the review and non billable checks but I don't think such an edge-case would ever occur.

same goes for already verified reports; if one is verified on one day, why would anyone create a second activity.

After all this seems to me like very bad client-side validation

Originally posted by @gianklug in #24 (comment)

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions