[MIG] l10n_ar_ux: added post-migration script

Author: jue-adhoc

l10n_ar_ux/19.0.1.0.0/post-migration.py

@@ -0,0 +1,98 @@
+import logging
+
+from openupgradelib import openupgrade_merge_records
+
+from odoo import SUPERUSER_ID, api
+
+logger = logging.getLogger(__name__)
+
+
+def _cleanup_orphan_references(cr, model_table):
+    """Nullify references to activities that no longer exist after merging."""
+    logger.info("Cleaning up orphan references to %s", model_table)
+    column = "l10n_ar_arca_activity_id"
+    for table in ["res_company", "account_account"]:
+        cr.execute(
+            f"""
+            UPDATE {table}
+            SET {column} = NULL
+            WHERE NOT EXISTS (
+                SELECT 1 FROM {model_table} WHERE id = {table}.{column}
+            )
+            """
+        )
+        if cr.rowcount:
+            logger.info(
+                "Cleaned %d orphan references in table '%s'", cr.rowcount, table
+            )
+
+
+def migrate(cr, version):
+    """Merge duplicate records in l10n_ar.arca.activity based on the 'code' field.
+
+    This handles the case where activities were user-created in the old model (afip.padron)
+    but are now created as data in the new model (l10n_ar.arca.activity), which can lead
+    to duplicates after migration.
+    """
+    model_name = "l10n_ar.arca.activity"
+    model_table = "l10n_ar_arca_activity"
+
+    # Find duplicate codes
+    cr.execute(
+        f"""
+        SELECT code, array_agg(id ORDER BY id) as ids
+        FROM {model_table}
+        WHERE code IS NOT NULL
+        GROUP BY code
+        HAVING COUNT(*) > 1
+        """
+    )
+
+    duplicates = cr.fetchall()
+    if not duplicates:
+        logger.info("No duplicate activities found based on 'code' field")
+        return
+
+    logger.info("Found %s groups of duplicate activities to merge", len(duplicates))
+    env = api.Environment(cr, SUPERUSER_ID, {})
+
+    for code, record_ids in duplicates:
+        if len(record_ids) < 2:
+            continue
+
+        # Use the last record (highest ID) as target, which is the original user-created record
+        # The lower IDs are typically the new data records that were loaded
+        target_record_id = record_ids[-1]
+        records_to_merge = record_ids[:-1]
+
+        logger.info(
+            "Merging duplicate activities with code '%s': merging %s into %s",
+            code,
+            records_to_merge,
+            target_record_id,
+        )
+
+        try:
+            openupgrade_merge_records.merge_records(
+                env=env,
+                model_name=model_name,
+                record_ids=records_to_merge,
+                target_record_id=target_record_id,
+                method="sql",
+                delete=True,
+                model_table=model_table,
+            )
+            logger.info(
+                "Successfully merged %s duplicate records into record %s",
+                len(records_to_merge),
+                target_record_id,
+            )
+        except Exception as e:
+            logger.error(
+                "Error merging duplicate activities with code '%s': %s", code, str(e)
+            )
+            # Continue with next group even if one fails
+            continue
+
+    # Clean up any references that might have been broken after the merge
+    _cleanup_orphan_references(cr, model_table)

l10n_ar_ux/19.0.1.0.0/pre-migration.py

@@ -16,6 +16,12 @@ def migrate(cr, version):
     util.rename_model(cr, *model_renames)
     logger.info("Renaming model %s to %s", model_renames[0], model_renames[1])
 
+    # Update XML ID of the model to point to the new module
+    old_xmlid = f"{module_renames[0]}.model_l10n_ar_arca_activity"
+    new_xmlid = f"{module_renames[1]}.model_l10n_ar_arca_activity"
+    util.rename_xmlid(cr, old_xmlid, new_xmlid)
+    logger.info("Renamed XML ID from %s to %s", old_xmlid, new_xmlid)
+
     for model in models_to_migrate:
         # Rename field l10n_ar_afip_activity_id to l10n_ar_arca_activity_id
         util.rename_field(cr, model, old_fieldname, new_fieldname)