Skip to content

Commit 4639624

Browse files
committed
fix(cmd.help): usage label was printed even if no text
1 parent 9cac890 commit 4639624

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/Helper/OutputHelper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,11 @@ protected function showHelp(string $for, array $items, string $header = '', stri
196196
*
197197
* It replaces $0 with actual command name and properly pads ` ## ` segments.
198198
*
199-
* @param string|null $usage Usage description.
199+
* @param string $usage Usage description.
200200
*
201201
* @return self
202202
*/
203-
public function showUsage(string $usage = null): self
203+
public function showUsage(string $usage): self
204204
{
205205
$usage = \str_replace('$0', $_SERVER['argv'][0] ?? '[cmd]', $usage);
206206

src/Input/Command.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,11 @@ public function showHelp()
343343

344344
$helper
345345
->showArgumentsHelp($this->allArguments())
346-
->showOptionsHelp($this->allOptions(), '', 'Legend: <required> [optional] variadic...')
347-
->showUsage($this->_usage);
346+
->showOptionsHelp($this->allOptions(), '', 'Legend: <required> [optional] variadic...');
347+
348+
if ($this->_usage) {
349+
$helper->showUsage($this->_usage);
350+
}
348351

349352
return $this->emit('_exit', 0);
350353
}

0 commit comments

Comments
 (0)