refactor: extract methods

Author: adhocore

src/Expression.php

@@ -96,6 +96,15 @@ protected static function process($expr, $time)
             );
         }
 
+        $time = static::normalizeTime($time);
+
+        $time = array_map('intval', explode(' ', date('i G j n w Y t d m N', $time)));
+
+        return [$expr, $time];
+    }
+
+    protected static function normalizeTime($time)
+    {
         if (empty($time)) {
             $time = time();
         } elseif (is_string($time)) {
@@ -104,9 +113,7 @@ protected static function process($expr, $time)
             $time = $time->getTimestamp();
         }
 
-        $time = array_map('intval', explode(' ', date('i G j n w Y t d m N', $time)));
-
-        return [$expr, $time];
+        return $time;
     }
 
     protected static function isSegmentDue($segment, $pos, $time)
@@ -207,17 +214,22 @@ protected static function checkMonthDay($value, $time)
         if ($pos = strpos($value, 'W')) {
             $value = substr($value, 0, $pos);
 
-            foreach ([0, -1, 1, -2, 2] as $i) {
-                $incr = $value + $i;
-                if ($incr > 0 && $incr <= $time[6]) {
-                    if ($incr < 10) {
-                        $incr = '0' . $incr;
-                    }
-
-                    $parts = explode(' ', date('N m j', strtotime("$time[5]-$month-$incr")));
-                    if ($parts[0] < 6 && $parts[1] == $month) {
-                        return $time[2] == $parts[2];
-                    }
+            return static::isClosestWeekDay($value, $month, $time);
+        }
+    }
+
+    protected function isClosestWeekDay($value, $month, $time)
+    {
+        foreach ([0, -1, 1, -2, 2] as $i) {
+            $incr = $value + $i;
+            if ($incr > 0 && $incr <= $time[6]) {
+                if ($incr < 10) {
+                    $incr = '0' . $incr;
+                }
+
+                $parts = explode(' ', date('N m j', strtotime("$time[5]-$month-$incr")));
+                if ($parts[0] < 6 && $parts[1] == $month) {
+                    return $time[2] == $parts[2];
                 }
             }
         }
@@ -237,17 +249,8 @@ protected static function checkWeekDay($value, $time)
     {
         $month = $time[8] < 10 ? '0' . $time[8] : $time[8];
 
-        if ($pos = strpos($value, 'L')) {
-            $value = explode('L', str_replace('7L', '0L', $value));
-            $decr  = $time[6];
-            for ($i = 0; $i < 7; $i++) {
-                $decr -= $i;
-                if (date('w', strtotime("$time[5]-$month-$decr")) == $value[0]) {
-                    return $time[2] == $decr;
-                }
-            }
-
-            return false;
+        if (strpos($value, 'L')) {
+            return static::lasWeekDay($value, $month, $time);
         }
 
         if (strpos($value, '#')) {
@@ -261,6 +264,21 @@ protected static function checkWeekDay($value, $time)
         }
     }
 
+    protected static function lasWeekDay($value, $month, $time)
+    {
+        $value = explode('L', str_replace('7L', '0L', $value));
+        $decr  = $time[6];
+
+        for ($i = 0; $i < 7; $i++) {
+            $decr -= $i;
+            if (date('w', strtotime("$time[5]-$month-$decr")) == $value[0]) {
+                return $time[2] == $decr;
+            }
+        }
+
+        return false;
+    }
+
     /**
      * Instance call.
      *