Skip to content

Commit 816f711

Browse files
committed
fix: reduce args order should be (carry, item)
1 parent 5518eee commit 816f711

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/CollectionTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,26 +83,26 @@ public function test_map_collect()
8383

8484
public function test_reduce_foldl_inject()
8585
{
86-
$sum = _::_([1, 2, 3])->reduce(function ($num, $sum) {
86+
$sum = _::_([1, 2, 3])->reduce(function ($sum, $num) {
8787
return $num + $sum;
8888
}, 0);
8989

9090
$this->assertSame(6, $sum, 'sum by reduce');
9191

92-
$sum = _::_([1, 2, 3])->foldl(function ($num, $sum) {
92+
$sum = _::_([1, 2, 3])->foldl(function ($sum, $num) {
9393
return $num + $sum;
9494
}, 10);
9595

9696
$this->assertSame(10 + 6, $sum, 'sum by reduce with initial 10');
9797

98-
$prod = _::_([1, 2, 3, 4])->inject(function ($num, $sum) {
99-
return $num * $sum;
98+
$prod = _::_([1, 2, 3, 4])->inject(function ($prod, $num) {
99+
return $prod * $num;
100100
}, 1);
101101

102102
$this->assertSame(24, $prod, 'prod by reduce with initial 1');
103103

104-
$concat = _::_([1, 2, 3, 4])->inject(function ($num, $concat) {
105-
return $num . $concat;
104+
$concat = _::_([1, 2, 3, 4])->inject(function ($concat, $num) {
105+
return $concat . $num;
106106
}, '');
107107

108108
$this->assertSame('1234', $concat, 'concat by reduce');
@@ -116,8 +116,8 @@ public function test_reduceRight_foldr()
116116

117117
$this->assertSame(6, $sum, 'sum by reduceRight');
118118

119-
$concat = _::_([1, 2, 3, 4])->foldr(function ($num, $concat) {
120-
return $num . $concat;
119+
$concat = _::_([1, 2, 3, 4])->foldr(function ($concat, $num) {
120+
return $concat . $num;
121121
}, '');
122122

123123
$this->assertSame('4321', $concat, 'concat by reduceRight');

0 commit comments

Comments
 (0)