Stop referencing Microsoft.PowerShell.Security when the core snapin is used (PowerShell#17771)

Author: daxian-dbw

src/Modules/Unix/Microsoft.PowerShell.Security/Microsoft.PowerShell.Security.psd1

@@ -1,14 +1,14 @@
 @{
-GUID="A94C8C7E-9810-47C0-B8AF-65089C13A35A"
-Author="PowerShell"
-CompanyName="Microsoft Corporation"
-Copyright="Copyright (c) Microsoft Corporation."
-ModuleVersion="7.0.0.0"
+GUID = "A94C8C7E-9810-47C0-B8AF-65089C13A35A"
+Author = "PowerShell"
+CompanyName = "Microsoft Corporation"
+Copyright = "Copyright (c) Microsoft Corporation."
+ModuleVersion = "7.0.0.0"
 CompatiblePSEditions = @("Core")
-PowerShellVersion="3.0"
+PowerShellVersion = "3.0"
 FunctionsToExport = @()
-CmdletsToExport="Get-Credential", "Get-ExecutionPolicy", "Set-ExecutionPolicy", "ConvertFrom-SecureString", "ConvertTo-SecureString", "Get-PfxCertificate" , "Protect-CmsMessage", "Unprotect-CmsMessage", "Get-CmsMessage"
+CmdletsToExport = "Get-Credential", "Get-ExecutionPolicy", "Set-ExecutionPolicy", "ConvertFrom-SecureString", "ConvertTo-SecureString", "Get-PfxCertificate" , "Protect-CmsMessage", "Unprotect-CmsMessage", "Get-CmsMessage"
 AliasesToExport = @()
-NestedModules="Microsoft.PowerShell.Security.dll"
+NestedModules = "Microsoft.PowerShell.Security.dll"
 HelpInfoURI = 'https://aka.ms/powershell73-help'
 }

src/Modules/Windows/Microsoft.PowerShell.Security/Microsoft.PowerShell.Security.psd1

@@ -1,15 +1,18 @@
 @{
-GUID="A94C8C7E-9810-47C0-B8AF-65089C13A35A"
-Author="PowerShell"
-CompanyName="Microsoft Corporation"
-Copyright="Copyright (c) Microsoft Corporation."
-ModuleVersion="7.0.0.0"
+GUID = "A94C8C7E-9810-47C0-B8AF-65089C13A35A"
+Author = "PowerShell"
+CompanyName = "Microsoft Corporation"
+Copyright = "Copyright (c) Microsoft Corporation."
+ModuleVersion = "7.0.0.0"
 CompatiblePSEditions = @("Core")
-PowerShellVersion="3.0"
+PowerShellVersion = "3.0"
 FunctionsToExport = @()
-CmdletsToExport="Get-Acl", "Set-Acl", "Get-PfxCertificate", "Get-Credential", "Get-ExecutionPolicy", "Set-ExecutionPolicy", "Get-AuthenticodeSignature", "Set-AuthenticodeSignature", "ConvertFrom-SecureString", "ConvertTo-SecureString", "Get-CmsMessage", "Unprotect-CmsMessage", "Protect-CmsMessage" , "New-FileCatalog" , "Test-FileCatalog"
+CmdletsToExport = "Get-Acl", "Set-Acl", "Get-PfxCertificate", "Get-Credential", "Get-ExecutionPolicy", "Set-ExecutionPolicy", "Get-AuthenticodeSignature", "Set-AuthenticodeSignature", "ConvertFrom-SecureString", "ConvertTo-SecureString", "Get-CmsMessage", "Unprotect-CmsMessage", "Protect-CmsMessage" , "New-FileCatalog" , "Test-FileCatalog"
 AliasesToExport = @()
-NestedModules="Microsoft.PowerShell.Security.dll"
-TypesToProcess="Security.types.ps1xml"
+NestedModules = "Microsoft.PowerShell.Security.dll"
+# 'Security.types.ps1xml' refers to types from 'Microsoft.PowerShell.Security.dll' and thus requiring to load the assembly before processing the type file.
+# We declare 'Microsoft.PowerShell.Security.dll' in 'RequiredAssemblies' so as to make sure it's loaded before the type file processing.
+RequiredAssemblies = "Microsoft.PowerShell.Security.dll"
+TypesToProcess = "Security.types.ps1xml"
 HelpInfoURI = 'https://aka.ms/powershell73-help'
 }

src/System.Management.Automation/engine/InitialSessionState.cs

@@ -3851,13 +3851,6 @@ internal PSSnapInInfo ImportPSSnapIn(PSSnapInInfo psSnapInInfo, out PSSnapInExce
             assemblyEntry.SetPSSnapIn(psSnapInInfo);
             Assemblies.Add(assemblyEntry);
 
-            // entry from types.ps1xml references a type (Microsoft.PowerShell.Commands.SecurityDescriptorCommandsBase) in this assembly
-            if (psSnapInInfo.Name.Equals(CoreSnapin, StringComparison.OrdinalIgnoreCase))
-            {
-                assemblyEntry = new SessionStateAssemblyEntry("Microsoft.PowerShell.Security", null);
-                this.Assemblies.Add(assemblyEntry);
-            }
-
             if (cmdlets != null)
             {
                 foreach (SessionStateCmdletEntry cmdlet in cmdlets.Values)

test/powershell/Host/Startup.Tests.ps1

@@ -7,7 +7,6 @@ Describe "Validate start of console host" -Tag CI {
             'Microsoft.ApplicationInsights.dll'
             'Microsoft.Management.Infrastructure.dll'
             'Microsoft.PowerShell.ConsoleHost.dll'
-            'Microsoft.PowerShell.Security.dll'
             'Microsoft.Win32.Primitives.dll'
             'Microsoft.Win32.Registry.dll'
             'netstandard.dll'