Skip to content

Commit c2323db

Browse files
authored
Re-enable tests because the corresponding dotnet issues were fixed (PowerShell#17839)
1 parent 8950962 commit c2323db

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

test/powershell/Host/ConsoleHost.Tests.ps1

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,8 +1106,7 @@ Describe 'Pwsh startup and PATH' -Tag CI {
11061106
}
11071107

11081108
Describe 'Console host name' -Tag CI {
1109-
It 'Name is pwsh' -Pending {
1110-
# waiting on https://github.com/dotnet/runtime/issues/33673
1109+
It 'Name is pwsh' {
11111110
(Get-Process -Id $PID).Name | Should -BeExactly 'pwsh'
11121111
}
11131112
}

test/powershell/Language/Parser/Parser.Tests.ps1

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -867,9 +867,7 @@ foo``u{2195}abc
867867
@{ Script = "0x12"; ExpectedValue = "18"; ExpectedType = [int] }
868868
@{ Script = "-0x12"; ExpectedValue = "-18"; ExpectedType = [int] }
869869

870-
# Disabling this because https://github.com/dotnet/runtime/issues/54251
871-
# @{ Script = "0x80000000"; ExpectedValue = $([int32]::MinValue); ExpectedType = [int] }
872-
870+
@{ Script = "0x80000000"; ExpectedValue = $([int32]::MinValue); ExpectedType = [int] }
873871
@{ Script = "0x7fffffff"; ExpectedValue = $([int32]::MaxValue); ExpectedType = [int] }
874872
@{ Script = "0x100000000"; ExpectedValue = [int64]0x100000000; ExpectedType = [long] }
875873
@{ Script = "0xFF"; ExpectedValue = "255"; ExpectedType = [int] }
@@ -1053,9 +1051,7 @@ foo``u{2195}abc
10531051
@{ Script = "0xFFFFu"; ExpectedValue = "65535"; ExpectedType = [uint] }
10541052
@{ Script = "0xFFFFFFu"; ExpectedValue = "16777215"; ExpectedType = [uint] }
10551053

1056-
# Disabling this because https://github.com/dotnet/runtime/issues/54251
1057-
# @{ Script = "0xFFFFFFFFu"; ExpectedValue = "$([uint]::MaxValue)"; ExpectedType = [uint] }
1058-
1054+
@{ Script = "0xFFFFFFFFu"; ExpectedValue = "$([uint]::MaxValue)"; ExpectedType = [uint] }
10591055
@{ Script = "0xFFFFFFFFFFu"; ExpectedValue = "1099511627775"; ExpectedType = [ulong] }
10601056
@{ Script = "0xFFFFFFFFFFFFu"; ExpectedValue = "281474976710655"; ExpectedType = [ulong] }
10611057
@{ Script = "0xFFFFFFFFFFFFFFu"; ExpectedValue = "72057594037927935"; ExpectedType = [ulong] }
@@ -1065,10 +1061,7 @@ foo``u{2195}abc
10651061
@{ Script = "0b10u"; ExpectedValue = "2"; ExpectedType = [uint] }
10661062
@{ Script = "0b11111111u"; ExpectedValue = "255"; ExpectedType = [uint] }
10671063
@{ Script = "0b1111111111111111u"; ExpectedValue = "65535"; ExpectedType = [uint] }
1068-
1069-
# Disabling this because https://github.com/dotnet/runtime/issues/54251
1070-
# @{ Script = "0b11111111111111111111111111111111u"; ExpectedValue = "4294967295"; ExpectedType = [uint] }
1071-
1064+
@{ Script = "0b11111111111111111111111111111111u"; ExpectedValue = "4294967295"; ExpectedType = [uint] }
10721065
@{ Script = "0b1111111111111111111111111111111111111111111111111111111111111111u"; ExpectedValue = "18446744073709551615"; ExpectedType = [ulong] }
10731066
#Multipliers
10741067
@{ Script = "1ukb"; ExpectedValue = "1024"; ExpectedType = [uint] }

test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ function GetExternalHostAddress([string]$HostName)
3232
}
3333
}
3434

35-
# Adding RequireSudoOnUnix due to issue: https://github.com/dotnet/runtime/issues/66746
35+
# Adding RequireSudoOnUnix due to an intentional breaking change.
36+
# See https://github.com/dotnet/runtime/issues/66746
3637
Describe "Test-Connection" -tags "CI", "RequireSudoOnUnix" {
3738
BeforeAll {
3839
$hostName = [System.Net.Dns]::GetHostName()

0 commit comments

Comments
 (0)