Skip to content

Commit 0140056

Browse files
uercegshashanksu
authored andcommitted
refac: use AdjustDeeplink throughout instead of separate Uri instances
1 parent 9bca80b commit 0140056

File tree

3 files changed

+23
-14
lines changed

3 files changed

+23
-14
lines changed

Adjust/sdk-core/src/main/java/com/adjust/sdk/ActivityHandler.java

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -443,22 +443,24 @@ private boolean isEnabledI() {
443443
}
444444

445445
@Override
446-
public void processDeeplink(final Uri url, Uri referrer, final long clickTime) {
446+
public void processDeeplink(final AdjustDeeplink deeplink, final long clickTime) {
447447
executor.submit(new Runnable() {
448448
@Override
449449
public void run() {
450-
processDeeplinkI(url, referrer, clickTime);
450+
processDeeplinkI(deeplink, clickTime);
451451
}
452452
});
453453
}
454454

455455
@Override
456-
public void processAndResolveDeeplink(final Uri url, final Uri referrer, final long clickTime, final OnDeeplinkResolvedListener callback) {
456+
public void processAndResolveDeeplink(final AdjustDeeplink deeplink,
457+
final long clickTime,
458+
final OnDeeplinkResolvedListener callback) {
457459
this.cachedDeeplinkResolutionCallback = callback;
458460
executor.submit(new Runnable() {
459461
@Override
460462
public void run() {
461-
processDeeplinkI(url, referrer, clickTime);
463+
processDeeplinkI(deeplink, clickTime);
462464
}
463465
});
464466
}
@@ -1550,7 +1552,9 @@ private void processCachedDeeplinkI() {
15501552
return;
15511553
}
15521554

1553-
processDeeplink(Uri.parse(cachedDeeplinkUrl), Uri.parse(cachedDeeplinkReferrer), cachedDeeplinkClickTime);
1555+
AdjustDeeplink deeplink = new AdjustDeeplink(Uri.parse(cachedDeeplinkUrl));
1556+
deeplink.setReferrer(Uri.parse(cachedDeeplinkReferrer));
1557+
processDeeplink(deeplink, cachedDeeplinkClickTime);
15541558

15551559
sharedPreferencesManager.removeDeeplink();
15561560
}
@@ -2111,19 +2115,24 @@ private boolean isValidReferrerDetails(final ReferrerDetails referrerDetails) {
21112115
return referrerDetails.installReferrer.length() != 0;
21122116
}
21132117

2114-
private void processDeeplinkI(Uri url, Uri referrer, long clickTime) {
2118+
private void processDeeplinkI(AdjustDeeplink deeplink, long clickTime) {
21152119
if (!isEnabledI()) {
21162120
return;
21172121
}
2122+
if (deeplink == null) {
2123+
return;
2124+
}
21182125

2119-
if (Util.isUrlFilteredOut(url)) {
2120-
logger.debug("Deeplink (" + url.toString() + ") processing skipped");
2126+
if (Util.isUrlFilteredOut(deeplink.getUrl())) {
2127+
if (deeplink.getUrl() != null) {
2128+
logger.debug("Deeplink (" + deeplink.getUrl().toString() + ") processing skipped");
2129+
}
21212130
return;
21222131
}
21232132

21242133
ActivityPackage sdkClickPackage = PackageFactory.buildDeeplinkSdkClickPackage(
2125-
url,
2126-
referrer,
2134+
deeplink.getUrl(),
2135+
deeplink.getReferrer(),
21272136
clickTime,
21282137
activityState,
21292138
adjustConfig,

Adjust/sdk-core/src/main/java/com/adjust/sdk/AdjustInstance.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ public void processDeeplink(final AdjustDeeplink adjustDeeplink, final Context c
213213
return;
214214
}
215215

216-
activityHandler.processDeeplink(adjustDeeplink.url, adjustDeeplink.referrer, clickTime);
216+
activityHandler.processDeeplink(adjustDeeplink, clickTime);
217217
}
218218

219219
/**
@@ -248,7 +248,7 @@ public void processAndResolveDeeplink(AdjustDeeplink adjustDeeplink, Context con
248248
}
249249

250250
// if deeplink processing was triggered with SDK being initialized
251-
activityHandler.processAndResolveDeeplink(adjustDeeplink.url, adjustDeeplink.referrer, clickTime, callback);
251+
activityHandler.processAndResolveDeeplink(adjustDeeplink, clickTime, callback);
252252
}
253253

254254
/**

Adjust/sdk-core/src/main/java/com/adjust/sdk/IActivityHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ public interface IActivityHandler {
2222
boolean isEnabled();
2323
void isEnabled(OnIsEnabledListener onIsEnabledListener);
2424

25-
void processDeeplink(Uri url, Uri referrer, long clickTime);
25+
void processDeeplink(AdjustDeeplink deeplink, long clickTime);
2626

27-
void processAndResolveDeeplink(Uri url, Uri referrer, long clickTime, OnDeeplinkResolvedListener callback);
27+
void processAndResolveDeeplink(AdjustDeeplink deeplink, long clickTime, OnDeeplinkResolvedListener callback);
2828

2929
boolean updateAttributionI(AdjustAttribution attribution);
3030

0 commit comments

Comments
 (0)