Skip to content

Conversation

@pull
Copy link

@pull pull bot commented May 13, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Release version 1.3.14 with fix for single time-shift reference handling, support for SQL join hints, updated rolling window documentation and examples, and corresponding tests and version bumps.

New Features:

  • Rewrite joins from SQL as query-level join hints

Bug Fixes:

  • Fix schema-compiler view queries for measures with a single time-shift reference without a time dimension

Enhancements:

  • Expand multi-stage calculations docs with rolling window concept, examples, and Tesseract engine warnings

Tests:

  • Add integration test covering time-shift without an explicit time dimension

Chores:

  • Bump version to 1.3.14 across all packages

@pull pull bot added the ⤵️ pull label May 13, 2025
@pull pull bot merged commit 91c5e87 into admariner:master May 13, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented May 13, 2025

Reviewer's Guide

This PR advances Cube.js to v1.3.14 by enriching the documentation with detailed rolling-window guidance and Tesseract notes, bumping versions across all packages, and introducing a schema-compiler bugfix (with accompanying tests) to support single-timeshift measures without an explicit time dimension.

File-Level Changes

Change Details Files
Add comprehensive rolling window content in docs
  • Insert a new "Rolling window" section with stages and example YAML
  • Extend multi-stage calculations doc to mention CTE generation
  • Update reference measures doc to define offset, trailing, and leading parameters
  • Add Tesseract warning boxes to multi-stage and period-over-period guides
docs/pages/product/data-modeling/concepts/multi-stage-calculations.mdx
docs/pages/reference/data-model/measures.mdx
docs/pages/guides/recipes/data-modeling/period-over-period.mdx
Bump project version to 1.3.14 across packages
  • Increment top-level and each package.json version from 1.3.13 to 1.3.14
  • Update internal dependency versions in all backend, driver, CLI, client, and Rust crates
lerna.json
**/package.json
**/CHANGELOG.md
Fix schema-compiler time-shift alias handling
  • Ignore aliased time dimensions when checking existing shiftIntervals
  • Prevent hierarchical time shift error for single reference without time dimension
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
Add new integration test for time-shift measures
  • Introduce a PostgreSQL SQL generation test for CAGR without explicit timeDimension in a time shift view
packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts
Document 1.3.14 changelog entry CHANGELOG.md
packages/**/CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (2b2ac1c) to head (91c5e87).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         230      230           
  Lines       84409    84409           
=======================================
  Hits        68667    68667           
  Misses      15742    15742           
Flag Coverage Δ
cubesql 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants