Skip to content
This repository was archived by the owner on Sep 15, 2023. It is now read-only.

Commit 95d906a

Browse files
authored
Merge pull request #43 from admin-ch/feature/cfenv
2 parents 06f01c3 + ab5732a commit 95d906a

File tree

9 files changed

+19
-60
lines changed

9 files changed

+19
-60
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212
- uses: actions/checkout@v3
1313
with:
1414
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
15-
- name: Set up JDK 11
15+
- name: Set up JDK 17
1616
uses: actions/setup-java@v3
1717
with:
18-
java-version: 11
18+
java-version: 17
1919
distribution: 'zulu'
2020
- name: Cache SonarCloud packages
2121
uses: actions/cache@v3

.github/workflows/tagged_release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ jobs:
1313
- uses: actions/checkout@v3
1414
- run: |
1515
git fetch --no-tags --prune --depth=1 origin +refs/heads/*:refs/remotes/origin/*
16-
- name: Set up JDK 11
16+
- name: Set up JDK 17
1717
uses: actions/setup-java@v3
1818
with:
19-
java-version: 11.0.7
19+
java-version: 17
2020
server-id: github # Value of the distributionManagement/repository/id field of the pom.xml
2121
settings-path: ${{ github.workspace }} # location for the settings.xml file: :
2222
distribution: 'zulu'

ch-covidcertificate-backend-delivery/ch-covidcertificate-backend-delivery-data/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<dependency>
3737
<groupId>org.postgresql</groupId>
3838
<artifactId>postgresql</artifactId>
39-
<version>42.4.0</version>
39+
<version>42.5.0</version>
4040
</dependency>
4141
<dependency>
4242
<groupId>org.flywaydb</groupId>

ch-covidcertificate-backend-delivery/ch-covidcertificate-backend-delivery-ws/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@
3939
<groupId>io.micrometer</groupId>
4040
<artifactId>micrometer-registry-prometheus</artifactId>
4141
</dependency>
42-
<dependency>
43-
<groupId>org.springframework.boot</groupId>
44-
<artifactId>spring-boot-starter-cloud-connectors</artifactId>
45-
<version>${spring-cloud-connectors-version}</version>
46-
</dependency>
4742
<dependency>
4843
<groupId>org.springframework.boot</groupId>
4944
<artifactId>spring-boot-starter-validation</artifactId>

ch-covidcertificate-backend-delivery/ch-covidcertificate-backend-delivery-ws/src/main/java/ch/admin/bag/covidcertificate/backend/delivery/ws/config/WsBaseConfig.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ public abstract class WsBaseConfig implements WebMvcConfigurer {
6161
"#{${ws.security.headers: {'X-Content-Type-Options':'nosniff', 'X-Frame-Options':'DENY','X-Xss-Protection':'1; mode=block'}}}")
6262
Map<String, String> additionalHeaders;
6363

64-
public abstract DataSource dataSource();
65-
66-
public abstract Flyway flyway();
64+
public abstract Flyway flyway(DataSource dataSource);
6765

6866
public abstract IosHeartbeatSilentPush iosHeartbeatSilentPush(
6967
DeliveryDataService pushRegistrationDataService);

ch-covidcertificate-backend-delivery/ch-covidcertificate-backend-delivery-ws/src/main/java/ch/admin/bag/covidcertificate/backend/delivery/ws/config/WsCloudBaseConfig.java

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,12 @@
88
import javax.sql.DataSource;
99
import org.flywaydb.core.Flyway;
1010
import org.springframework.beans.factory.annotation.Value;
11-
import org.springframework.cloud.CloudFactory;
12-
import org.springframework.cloud.service.PooledServiceConnectorConfig.PoolConfig;
13-
import org.springframework.cloud.service.relational.DataSourceConfig;
1411
import org.springframework.context.annotation.Bean;
1512
import org.springframework.context.annotation.Configuration;
1613

1714
@Configuration
1815
public abstract class WsCloudBaseConfig extends WsBaseConfig {
1916

20-
@Value("${datasource.maximumPoolSize:5}")
21-
int dataSourceMaximumPoolSize;
22-
23-
@Value("${datasource.connectionTimeout:30000}")
24-
int dataSourceConnectionTimeout;
25-
26-
@Value("${datasource.leakDetectionThreshold:0}")
27-
int dataSourceLeakDetectionThreshold;
28-
2917
@Value("${push.ios.signingkey}") // base64 encoded p8 file
3018
private String iosPushSigningKey;
3119

@@ -38,27 +26,13 @@ public abstract class WsCloudBaseConfig extends WsBaseConfig {
3826
@Value("${push.ios.topic}")
3927
private String iosPushTopic;
4028

41-
@Bean
42-
@Override
43-
public DataSource dataSource() {
44-
PoolConfig poolConfig =
45-
new PoolConfig(dataSourceMaximumPoolSize, dataSourceConnectionTimeout);
46-
DataSourceConfig dbConfig =
47-
new DataSourceConfig(
48-
poolConfig,
49-
null,
50-
null,
51-
Map.of("leakDetectionThreshold", dataSourceLeakDetectionThreshold));
52-
CloudFactory factory = new CloudFactory();
53-
return factory.getCloud().getSingletonServiceConnector(DataSource.class, dbConfig);
54-
}
5529

5630
@Bean
5731
@Override
58-
public Flyway flyway() {
32+
public Flyway flyway(DataSource dataSource) {
5933
Flyway flyWay =
6034
Flyway.configure()
61-
.dataSource(dataSource())
35+
.dataSource(dataSource)
6236
.locations("classpath:/db/migration/pgsql_cluster")
6337
.load();
6438
flyWay.migrate();

ch-covidcertificate-backend-delivery/ch-covidcertificate-backend-delivery-ws/src/main/java/ch/admin/bag/covidcertificate/backend/delivery/ws/config/WsLocalConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,10 @@ public DataSource dataSource() {
6262

6363
@Bean
6464
@Override
65-
public Flyway flyway() {
65+
public Flyway flyway(DataSource dataSource) {
6666
Flyway flyWay =
6767
Flyway.configure()
68-
.dataSource(dataSource())
68+
.dataSource(dataSource)
6969
.locations("classpath:/db/migration/pgsql")
7070
.load();
7171
flyWay.migrate();

ch-covidcertificate-backend-delivery/ch-covidcertificate-backend-delivery-ws/src/test/java/ch/admin/bag/covidcertificate/backend/delivery/ws/config/TestConfig.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,9 @@
2626
public class TestConfig extends WsBaseConfig {
2727
private static final Logger logger = LoggerFactory.getLogger(TestConfig.class);
2828

29-
@Autowired DataSource dataSource;
30-
31-
@Override
32-
public DataSource dataSource() {
33-
return dataSource;
34-
}
35-
3629
@Bean
3730
@Override
38-
public Flyway flyway() {
31+
public Flyway flyway(DataSource dataSource) {
3932
final var flyway =
4033
Flyway.configure()
4134
.dataSource(dataSource)

ch-covidcertificate-backend-delivery/pom.xml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,17 @@
1111
<name>CH Covidcertificate Delivery Backend</name>
1212

1313
<properties>
14-
<java-version>11</java-version>
14+
<java-version>17</java-version>
1515

1616
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1717
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
1818

19-
<spring-boot-version>2.7.2</spring-boot-version>
19+
<spring-boot-version>2.7.5</spring-boot-version>
2020
<jackson-version>2.11.1</jackson-version>
2121
<jsonwebtoken-version>0.11.5</jsonwebtoken-version>
22-
<testcontainers-version>1.17.3</testcontainers-version>
23-
<shedlock.version>4.39.0</shedlock.version>
24-
<spring-cloud-connectors-version>2.2.13.RELEASE</spring-cloud-connectors-version>
25-
<spring-cloud-sleuth-version>3.1.3</spring-cloud-sleuth-version>
22+
<testcontainers-version>1.17.6</testcontainers-version>
23+
<shedlock.version>4.42.0</shedlock.version>
24+
<spring-cloud-sleuth-version>3.1.5</spring-cloud-sleuth-version>
2625

2726
<itCoverageAgent/>
2827

@@ -66,13 +65,13 @@
6665
<dependency>
6766
<groupId>org.junit.jupiter</groupId>
6867
<artifactId>junit-jupiter-api</artifactId>
69-
<version>5.9.0</version>
68+
<version>5.9.1</version>
7069
<scope>test</scope>
7170
</dependency>
7271
<dependency>
7372
<groupId>org.junit.jupiter</groupId>
7473
<artifactId>junit-jupiter-engine</artifactId>
75-
<version>5.9.0</version>
74+
<version>5.9.1</version>
7675
<scope>test</scope>
7776
</dependency>
7877
<!-- testcontainers -->
@@ -103,7 +102,7 @@
103102
<dependency>
104103
<groupId>ch.admin.bag.covidcertificate</groupId>
105104
<artifactId>cc-backend-logging</artifactId>
106-
<version>1.0.3</version>
105+
<version>1.0.4</version>
107106
</dependency>
108107

109108
<!-- LogBack dependencies -->

0 commit comments

Comments
 (0)