Fix GET_STATUS_URL in PromoOfferRequestTrackingCode and update request data handling

- Corrected the URL for GET_STATUS_URL to match the intended endpoint.
- Refactored the request method to use a dictionary for request data instead of setting parameters directly, improving clarity and maintainability.

Author: nnnLik

admitad/items/promo_offers.py

@@ -44,7 +44,7 @@ class PromoOfferRequestTrackingCode(Item):
     SCOPE = 'request_tracking_coupon'
 
     CREATE_URL = Item.prepare_url('tracking_promo_code/request-tracking-coupon')
-    GET_STATUS_URL = Item.prepare_url('tracking_promo_codes/request-status')
+    GET_STATUS_URL = Item.prepare_url('tracking_promo_code/request-status')
 
     def create(
         self,
@@ -98,8 +98,12 @@ def get(self, request_id: int) -> dict:
         """
         request_id = Item.sanitize_id(request_id)
 
+        request_data = {
+            'request_id': request_id,
+        }
+
         return (
             self.transport.get()
-            .set_params({'request_id': request_id})
+            .set_data(request_data)
             .request(url=self.GET_STATUS_URL)
         )

admitad/tests/test_promo_offers.py

@@ -31,7 +31,7 @@ def test_request_tracking_promo_code_success(self) -> None:
         with responses.RequestsMock() as resp:
             resp.add(
                 resp.POST,
-                PromoOfferRequestTrackingCode.URL,
+                PromoOfferRequestTrackingCode.CREATE_URL,
                 json={
                     'assigned_promo_code': 'TESTCODE123',
                     'tracking_link': 'https://ad.admitad.com/g/123abc/'
@@ -52,7 +52,7 @@ def test_request_tracking_promo_code_creates_request(self) -> None:
         with responses.RequestsMock() as resp:
             resp.add(
                 resp.POST,
-                PromoOfferRequestTrackingCode.URL,
+                PromoOfferRequestTrackingCode.CREATE_URL,
                 json={
                     'assigned_promo_code': None,
                     'tracking_link': None,
@@ -76,7 +76,7 @@ def test_request_tracking_promo_code_no_coupon_error(self) -> None:
         with responses.RequestsMock() as resp:
             resp.add(
                 resp.POST,
-                PromoOfferRequestTrackingCode.URL,
+                PromoOfferRequestTrackingCode.CREATE_URL,
                 json={
                     'error_code': 'CHECK_PRE_APPROVED_COUPON_ERROR_CODE_NO_COUPON'
                 },
@@ -93,7 +93,7 @@ def test_request_tracking_promo_code_not_connected_error(self) -> None:
         with responses.RequestsMock() as resp:
             resp.add(
                 resp.POST,
-                PromoOfferRequestTrackingCode.URL,
+                PromoOfferRequestTrackingCode.CREATE_URL,
                 json={
                     'error_code': 'webmaster_not_connected'
                 },
@@ -130,6 +130,46 @@ def test_request_tracking_promo_code_invalid_website_id(self) -> None:
                 website_id=0,
             )
 
+    def test_get_tracking_promo_code_request_status_success(self) -> None:
+        with responses.RequestsMock() as resp:
+            resp.add(
+                resp.GET,
+                PromoOfferRequestTrackingCode.GET_STATUS_URL,
+                json={
+                    "request_id": 8,
+                    "promo_offer_id": 100,
+                    "website_id": 300,
+                    "status": "approved",
+                    "approved_at": "2023-01-01T12:00:00Z",
+                    "declined_at": None,
+                    "created_at": "2023-01-01T10:00:00Z",
+                    "assigned_promo_code": "TESTCODE123"
+                },
+                status=200
+            )
+            result = self.client.PromoOfferRequestTrackingCode.get(request_id=8)
+
+        self.assertIn('request_id', result)
+        self.assertIn('status', result)
+        self.assertEqual(result['request_id'], 8)
+        self.assertEqual(result['status'], 'approved')
+        self.assertEqual(result['assigned_promo_code'], 'TESTCODE123')
+
+    def test_get_tracking_promo_code_request_status_not_found(self) -> None:
+        with responses.RequestsMock() as resp:
+            resp.add(
+                resp.GET,
+                PromoOfferRequestTrackingCode.GET_STATUS_URL,
+                json={"err_code": "PROMO_REQUEST_NOT_FOUND"},
+                status=404
+            )
+            with self.assertRaises(HttpException):
+                self.client.PromoOfferRequestTrackingCode.get(request_id=999)
+
+    def test_get_tracking_promo_code_request_invalid_id(self) -> None:
+        with self.assertRaises(ValueError):
+            self.client.PromoOfferRequestTrackingCode.get(request_id=0)
+
 
 if __name__ == '__main__':
     unittest.main()