Use snprintf

josh-hadley · josh-hadley · commit 62eb83aebacc · 2021-03-12T21:31:55.000-08:00
diff --git a/src/_pyots/pyots-context.h b/src/_pyots/pyots-context.h
@@ -45,15 +45,15 @@ class PyOTSContext: public OTSContext {
     }
 
     if (level == 0) {
-      offset += sprintf(buff + offset, "ERROR: ");
+      offset += snprintf(buff + offset, buffsize - offset, "ERROR: ");
     } else {
-      offset += sprintf(buff + offset, "WARNING: ");
+      offset += snprintf(buff + offset, buffsize - offset, "WARNING: ");
     }
 
     va_start(va, format);
     offset += vsnprintf(buff + offset, buffsize - offset, format, va);
     va_end(va);
-    offset += sprintf(buff + offset, "\n");
+    offset += snprintf(buff + offset, buffsize - offset, "\n");
     }
 
   TableAction GetTableAction(uint32_t tag) {

Original file line number	Diff line number	Diff line change
`@@ -45,15 +45,15 @@ class PyOTSContext: public OTSContext {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`if (level == 0) {`
`48`		`- offset += sprintf(buff + offset, "ERROR: ");`
	`48`	`+ offset += snprintf(buff + offset, buffsize - offset, "ERROR: ");`
`49`	`49`	`} else {`
`50`		`- offset += sprintf(buff + offset, "WARNING: ");`
	`50`	`+ offset += snprintf(buff + offset, buffsize - offset, "WARNING: ");`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`va_start(va, format);`
`54`	`54`	`offset += vsnprintf(buff + offset, buffsize - offset, format, va);`
`55`	`55`	`va_end(va);`
`56`		`- offset += sprintf(buff + offset, "\n");`
	`56`	`+ offset += snprintf(buff + offset, buffsize - offset, "\n");`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`TableAction GetTableAction(uint32_t tag) {`