Skip to content

Commit b87db0f

Browse files
authored
fix: image with caption margins and puppeteer fix (#231)
1 parent 398db0b commit b87db0f

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

.github/workflows/tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
run: |
2626
BRANCH_NAME="${GITHUB_HEAD_REF:-${GITHUB_REF##*/}}"
2727
echo "Branch Name: ${BRANCH_NAME}"
28-
BASE_URL="https://${BRANCH_NAME}--adobe-design-website--adobe.hlx.page/"
28+
BASE_URL="https://${BRANCH_NAME}--adobe-design-website--adobe.aem.page/"
2929
echo "BASE_URL=${BASE_URL}"
3030
echo "BASE_URL=${BASE_URL}" >> $GITHUB_ENV
3131

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ This project contains code that is featured in the [AEM Block Collection](https:
44

55
## Environments
66

7-
- Preview: https://main--adobe-design-website--adobe.hlx.page/
8-
- Live: https://main--adobe-design-website--adobe.hlx.live/
7+
- Preview: https://main--adobe-design-website--adobe.aem.page/
8+
- Live: https://main--adobe-design-website--adobe.aem.live/
99

1010
## Quick Start
1111

blocks/article-header/article-header.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,3 +196,7 @@
196196
line-height: 1.25;
197197
}
198198
}
199+
200+
.article-header + .image-with-caption {
201+
margin-block-start: 0;
202+
}

blocks/quote/quote.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
}
1616

1717
@media (min-width: 80rem) {
18-
padding-block: 4.5rem;
18+
padding-block: 3.0rem;
1919
margin-block: 4.0rem;
2020
}
2121
}

styles/global-blocks.css

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -413,19 +413,10 @@
413413
display: flex;
414414
flex-direction: column;
415415
gap: var(--image-with-caption-gap);
416-
margin: 0;
417-
margin-block-end: 1.5rem;
418-
419-
& .image-with-caption--full-bleed {
420-
margin-block-end: 2.5rem;
421-
}
416+
margin: 1.5rem 0;
422417

423418
@media (min-width: 48rem) {
424-
margin-block-end: 2.5rem;
425-
}
426-
427-
@media (min-width: 80rem) {
428-
margin-block-end: 4rem;
419+
margin-block: 2.5rem;
429420
}
430421

431422
& .image-with-caption__image img {
@@ -468,6 +459,11 @@
468459
}
469460
}
470461

462+
.article-content article > :is(h2, h3) + .image-with-caption,
463+
.article-content article > div:has(> h2:last-child, > h3:last-child) + .image-with-caption {
464+
margin-block-start: 1.5rem;
465+
}
466+
471467
.image-with-caption div:has(p):not([class]) + .image-with-caption {
472468
margin-block-start: 2rem;
473469

0 commit comments

Comments
 (0)