fix: filter undefined projects (#769)

* fix: filter undefined projects

* chore: align test

* chore: make code more readable.

* Update src/extension/project.js

Co-authored-by: Raphael Wegmueller <github@rofe.com>

* chore: get rid of legacy

---------

Co-authored-by: Raphael Wegmueller <github@rofe.com>

Author: kptdobe

src/extension/project.js

@@ -48,9 +48,9 @@ export async function getProject(project = {}) {
  * @returns {Promise<Object[]>} The project configurations
  */
 export async function getProjects() {
-  return Promise.all((await getConfig('sync', 'projects')
-    || await getConfig('sync', 'hlxSidekickProjects') || []) // legacy
-    .map((handle) => getProject(handle)));
+  const configs = await getConfig('sync', 'projects') || [];
+  const projects = await Promise.all(configs.map((handle) => getProject(handle)));
+  return projects.filter((project) => project !== undefined);
 }
 
 /**
@@ -353,8 +353,7 @@ export async function deleteProject(project) {
     ({ owner, repo } = project);
     handle = `${owner}/${repo}`;
   }
-  const projects = await getConfig('sync', 'projects')
-    || await getConfig('sync', 'hlxSidekickProjects') || []; // legacy
+  const projects = await getConfig('sync', 'projects') || [];
   const i = projects.indexOf(handle);
   if (i >= 0) {
     // delete admin auth header rule

test/project.test.js

@@ -132,7 +132,6 @@ describe('Test project', () => {
       let value;
       switch (prop) {
         case 'projects':
-        case 'hlxSidekickProjects': // legacy
           value = ['foo/bar1'];
           break;
         case 'foo/bar1':
@@ -155,22 +154,9 @@ describe('Test project', () => {
     sandbox.restore();
     sandbox.stub(chrome.storage.sync, 'get')
       .withArgs('projects')
-      .resolves({})
-      .withArgs('hlxSidekickProjects')
       .resolves({});
     projects = await getProjects();
     expect(projects.length).to.equal(0);
-    // legacy projects
-    sandbox.restore();
-    sandbox.stub(chrome.storage.sync, 'get')
-      .withArgs('projects')
-      .resolves({})
-      .withArgs('hlxSidekickProjects')
-      .resolves({
-        hlxSidekickProjects: ['foo/bar1'],
-      });
-    projects = await getProjects();
-    expect(projects.length).to.equal(1);
   });
 
   it('getProjectEnv', async () => {