add unit tests for config-validate and fix formatting

Author: taub

src/BaseCommand.js

@@ -32,13 +32,13 @@ const {
 
 class BaseCommand extends Command {
   // default error handler for app commands
-  async catch(error) {
+  async catch (error) {
     const { flags } = await this.parse(this.prototype)
     aioLogger.error(error) // debug log
     this.error(flags.verbose && error.stack ? error.stack : error.message)
   }
 
-  async init() {
+  async init () {
     await super.init()
     // setup a prompt that outputs to stderr
     this.prompt = inquirer.createPromptModule({ output: process.stderr })
@@ -51,7 +51,7 @@ class BaseCommand extends Command {
       `aio-cli-plugin-app/${vs?.cliVersion} (${vs?.architecture}; ${vs?.nodeVersion}; ${vs?.shell})`
   }
 
-  async getLibConsoleCLI() {
+  async getLibConsoleCLI () {
     if (!this.consoleCLI) {
       // requires valid login
       const { accessToken, env } = await getAccessToken()
@@ -61,11 +61,11 @@ class BaseCommand extends Command {
     return this.consoleCLI
   }
 
-  async cleanConsoleCLIOutput() {
+  async cleanConsoleCLIOutput () {
     LibConsoleCLI.cleanStdOut()
   }
 
-  async getAppExtConfigs(flags, options = {}) {
+  async getAppExtConfigs (flags, options = {}) {
     const all = (await this.getFullConfig(options, flags)).all
 
     // default case: no flags, return all
@@ -96,7 +96,7 @@ class BaseCommand extends Command {
     return ret
   }
 
-  async getRuntimeManifestConfigFile(implName, flags) {
+  async getRuntimeManifestConfigFile (implName, flags) {
     let configKey
     if (implName === APPLICATION_CONFIG_KEY) {
       configKey = APPLICATION_CONFIG_KEY
@@ -112,7 +112,7 @@ class BaseCommand extends Command {
     return configData
   }
 
-  async getEventsConfigFile(implName, flags) {
+  async getEventsConfigFile (implName, flags) {
     let configKey
     if (implName === APPLICATION_CONFIG_KEY) {
       configKey = APPLICATION_CONFIG_KEY
@@ -128,7 +128,7 @@ class BaseCommand extends Command {
     return configData
   }
 
-  async getConfigFileForKey(fullKey, flags = {}) {
+  async getConfigFileForKey (fullKey, flags = {}) {
     // NOTE: the index returns undefined if the key is loaded from a legacy configuration file
     const fullConfig = await this.getFullConfig({}, flags)
     // full key like 'extensions.dx/excshell/1.runtimeManifest'
@@ -142,19 +142,18 @@ class BaseCommand extends Command {
     return configData || {}
   }
 
-  async getFullConfig(options = {}, flags = {}) {
+  async getFullConfig (options = {}, flags = {}) {
     // validate appConfig defaults to true unless flag is explicitly set to off
     const validateAppConfig = flags['config-validation'] !== false
     aioLogger.debug(`validateAppConfig=${validateAppConfig}`)
 
     if (!this.appConfig) {
-      // this will explicitly set validateAppConfig=false if not set
       this.appConfig = await appConfig.load({ ...options, validateAppConfig })
     }
     return this.appConfig
   }
 
-  getLaunchUrlPrefix() {
+  getLaunchUrlPrefix () {
     // todo: it might make sense to have a value that defines if this is an ExC hosted app, or otherwise
     // so we can decide what type of url to return here.
     // at some point we could also just delete the .env value and return our expected url here.
@@ -173,19 +172,19 @@ class BaseCommand extends Command {
     return (launchPrefix || defaultLaunchPrefix)
   }
 
-  get pjson() {
+  get pjson () {
     return this.config.pjson
   }
 
-  get appName() {
+  get appName () {
     return this.pjson.name
   }
 
-  get appVersion() {
+  get appVersion () {
     return this.pjson.version
   }
 
-  preRelease() {
+  preRelease () {
     this.log(chalk.yellow('Pre-release warning: This command is in pre-release, and not suitable for production.'))
   }
 }

src/commands/app/add/action.js

@@ -18,7 +18,7 @@ const TemplateRegistryAPI = require('@adobe/aio-lib-templates')
 const inquirer = require('inquirer')
 
 class AddActionCommand extends TemplatesCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(AddActionCommand)
 
     aioLogger.debug(`add actions with flags: ${JSON.stringify(flags)}`)
@@ -63,7 +63,7 @@ class AddActionCommand extends TemplatesCommand {
     }
   }
 
-  async getSearchCriteria(orgSupportedServices) {
+  async getSearchCriteria (orgSupportedServices) {
     const choices = [
       {
         name: 'All Action Templates',

src/commands/app/add/event.js

@@ -17,7 +17,7 @@ const path = require('path')
 const TemplateRegistryAPI = require('@adobe/aio-lib-templates')
 
 class AddEventCommand extends TemplatesCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(AddEventCommand)
 
     aioLogger.debug(`add events with flags: ${JSON.stringify(flags)}`)
@@ -56,7 +56,7 @@ class AddEventCommand extends TemplatesCommand {
     }
   }
 
-  async getSearchCriteria() {
+  async getSearchCriteria () {
     const TEMPLATE_CATEGORIES = ['events', 'helper-template']
     const searchCriteria = {
       [TemplateRegistryAPI.SEARCH_CRITERIA_STATUSES]: TemplateRegistryAPI.TEMPLATE_STATUS_APPROVED,

src/commands/app/add/extension.js

@@ -15,7 +15,7 @@ const { Flags } = require('@oclif/core')
 const TemplateRegistryAPI = require('@adobe/aio-lib-templates')
 
 class AddExtensionCommand extends TemplatesCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(AddExtensionCommand)
 
     aioLogger.debug(`add extensions with flags: ${JSON.stringify(flags)}`)
@@ -34,7 +34,7 @@ class AddExtensionCommand extends TemplatesCommand {
     }
   }
 
-  async selectExtensionsToInstall(alreadyImplemented, useDefaultValues, installNpm) {
+  async selectExtensionsToInstall (alreadyImplemented, useDefaultValues, installNpm) {
     const excludeExtensions = alreadyImplemented.map(e => `${TemplateRegistryAPI.SEARCH_CRITERIA_FILTER_NOT}${e}`)
 
     const orderByCriteria = {

src/commands/app/add/web-assets.js

@@ -15,7 +15,7 @@ const { Flags } = require('@oclif/core')
 const TemplateRegistryAPI = require('@adobe/aio-lib-templates')
 
 class AddWebAssetsCommand extends TemplatesCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(AddWebAssetsCommand)
     aioLogger.debug(`add web-assets with flags: ${JSON.stringify(flags)}`)
 

src/commands/app/config/get/log-forwarding.js

@@ -14,7 +14,7 @@ const LogForwarding = require('../../../../lib/log-forwarding')
 const { setRuntimeApiHostAndAuthHandler } = require('../../../../lib/auth-helper')
 
 class LogForwardingCommand extends BaseCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(LogForwardingCommand)
     let aioConfig = (await this.getFullConfig({}, flags)).aio
     aioConfig = setRuntimeApiHostAndAuthHandler(aioConfig)
@@ -38,7 +38,7 @@ class LogForwardingCommand extends BaseCommand {
     this.printConfig(serverConfig)
   }
 
-  printConfig(config) {
+  printConfig (config) {
     if (config.isDefined()) {
       this.log(`destination: ${config.getDestination()}`)
       this.log('settings:', config.getSettings())

src/commands/app/config/get/log-forwarding/errors.js

@@ -15,7 +15,7 @@ const ora = require('ora')
 const { setRuntimeApiHostAndAuthHandler } = require('../../../../../lib/auth-helper')
 
 class ErrorsCommand extends BaseCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(ErrorsCommand)
     const spinner = ora()
     const lf = await this.getLogForwarding(flags)
@@ -31,7 +31,7 @@ class ErrorsCommand extends BaseCommand {
     }
   }
 
-  async getLogForwarding(flags) {
+  async getLogForwarding (flags) {
     let aioConfig = (await this.getFullConfig({}, flags)).aio
     aioConfig = setRuntimeApiHostAndAuthHandler(aioConfig)
 

src/commands/app/config/set/log-forwarding.js

@@ -15,7 +15,7 @@ const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-
 const { setRuntimeApiHostAndAuthHandler } = require('../../../../lib/auth-helper')
 
 class LogForwardingCommand extends BaseCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(LogForwardingCommand)
     let aioConfig = (await this.getFullConfig({}, flags)).aio
     aioConfig = setRuntimeApiHostAndAuthHandler(aioConfig)
@@ -38,7 +38,7 @@ class LogForwardingCommand extends BaseCommand {
     })
   }
 
-  async promptDestination(supportedDestinations) {
+  async promptDestination (supportedDestinations) {
     const responses = await this.prompt([{
       name: 'type',
       message: 'select log forwarding destination',

src/commands/app/delete/action.js

@@ -20,7 +20,7 @@ const { EOL } = require('os')
 const { atLeastOne, deleteUserConfig } = require('../../../lib/app-helper')
 
 class DeleteActionCommand extends BaseCommand {
-  async run() {
+  async run () {
     const { args, flags } = await this.parse(DeleteActionCommand)
 
     aioLogger.debug(`deleting actions from the project, with args ${JSON.stringify(args)}, and flags: ${JSON.stringify(flags)}`)
@@ -108,7 +108,7 @@ class DeleteActionCommand extends BaseCommand {
     )))
   }
 
-  async getAllActions(config, flags = {}) {
+  async getAllActions (config, flags = {}) {
     const actions = []
     const actionsByImpl = {}
     const allConfigEntries = Object.entries(config.all)

src/commands/app/delete/extension.js

@@ -19,7 +19,7 @@ const fs = require('fs-extra')
 const { EOL } = require('os')
 
 class DeleteExtensionCommand extends BaseCommand {
-  async run() {
+  async run () {
     const { flags } = await this.parse(DeleteExtensionCommand)
 
     aioLogger.debug(`delete extension with flags: ${JSON.stringify(flags)}`)
@@ -52,7 +52,7 @@ class DeleteExtensionCommand extends BaseCommand {
     )))
   }
 
-  async selectOrGetConfigsToDelete(flags, config) {
+  async selectOrGetConfigsToDelete (flags, config) {
     const alreadyImplemented = config.implements
     if (alreadyImplemented.length <= 0) {
       throw new Error('There are no implementations left in the project')
@@ -71,7 +71,7 @@ class DeleteExtensionCommand extends BaseCommand {
     return await this.getAppExtConfigs(flags)
   }
 
-  async deleteImplementations(configs, flags) {
+  async deleteImplementations (configs, flags) {
     for (const [id, c] of Object.entries(configs)) {
       // delete actions
       if (c.app.hasBackend) {