fix(ipallowlists): exception on getBindingDetails fixes #707

* Update get-binding-details.js

* Update tests for get-binding-details.test.js

* Update get-binding-details.test.js

Author: rdurbalauadb

src/commands/cloudmanager/ip-allowlist/get-binding-details.js

@@ -26,7 +26,7 @@ class ListIPAllowlistBindingDetails extends BaseCommand {
 
     const result = await this.listIpAllowlists(programId, flags.imsContextName)
 
-    const allowList = result.find(allowList => allowList.id === args.ipAllowlistId)
+    const allowList = result.find(allowList => allowList.id === Number(args.ipAllowlistId))
 
     if (!allowList) {
       throw new validationCodes.IP_ALLOWLIST_NOT_FOUND({ messageValues: [args.ipAllowlistId, programId] })

test/commands/ip-allowlist/get-binding-details.test.js

@@ -37,7 +37,7 @@ test('get-binding-details - not found', async () => {
 
   mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
     {
-      id: '1',
+      id: 1,
       name: 'test1',
       ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
       programId: '4',
@@ -55,7 +55,7 @@ test('get-binding-details - no bindings', async () => {
 
   mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
     {
-      id: '1',
+      id: 1,
       name: 'test1',
       ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
       programId: '4',
@@ -66,7 +66,7 @@ test('get-binding-details - no bindings', async () => {
   const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await expect(runResult).resolves.toMatchObject({
-    id: '1',
+    id: 1,
     bindings: [],
   })
   await expect(mockSdk.listIpAllowlists.mock.calls.length).toEqual(1)
@@ -84,7 +84,7 @@ test('get-binding-details - normal with bindings', async () => {
 
   mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
     {
-      id: '1',
+      id: 1,
       name: 'test1',
       ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
       programId: '4',
@@ -98,7 +98,7 @@ test('get-binding-details - normal with bindings', async () => {
   const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await expect(runResult).resolves.toMatchObject({
-    id: '1',
+    id: 1,
     bindings: [{
       environmentId: '3',
       environmentName: 'TestProgram_dev',
@@ -114,7 +114,7 @@ test('get-binding-details - binding to unknown environment (should not ever happ
 
   mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
     {
-      id: '1',
+      id: 1,
       name: 'test1',
       ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
       programId: '4',
@@ -128,7 +128,7 @@ test('get-binding-details - binding to unknown environment (should not ever happ
   const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await expect(runResult).resolves.toMatchObject({
-    id: '1',
+    id: 1,
     bindings: [{
       environmentId: 'X',
       environmentName: 'Environment X',
@@ -144,7 +144,7 @@ test('get-binding-details - bindings when environment load fails', async () => {
 
   mockSdk.listIpAllowlists = jest.fn(() => Promise.resolve([
     {
-      id: '1',
+      id: 1,
       name: 'test1',
       ipCidrSet: ['1.1.1.1/5', '2.2.2.2/5'],
       programId: '4',
@@ -159,7 +159,7 @@ test('get-binding-details - bindings when environment load fails', async () => {
   const runResult = ListIPAllowlistBindingDetails.run(['--programId', '4', '1'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await expect(runResult).resolves.toMatchObject({
-    id: '1',
+    id: 1,
     bindings: [{
       environmentId: 'X',
       environmentName: 'Environment X',