fix(variables): passing an empty variable value should throw an error. fixes #305 (#306)

Author: justinedelson

src/cloudmanager-helpers.js

@@ -82,6 +82,9 @@ function createKeyValueObjectFromFlag (flag) {
         tempObj[flag[i]] = flag[i + 1]
       }
     }
+    if (Object.values(tempObj).filter(v => v === '').length) {
+      throw new Error('Blank variable values are not allowed. Use the proper flag if you intend to delete a variable.')
+    }
     return tempObj
   } else {
     throw (new Error('Please provide correct values for flags'))

test/commands/pipeline/set-variables.test.js

@@ -56,6 +56,19 @@ test('set-pipeline-variables - bad variable flag', async () => {
   await expect(runResult).rejects.toEqual(new Error('Please provide correct values for flags'))
 })
 
+test('set-pipeline-variables - empty variable flag', async () => {
+  setCurrentOrgId('good')
+  setStore({
+    cloudmanager_programid: '5',
+  })
+
+  expect.assertions(2)
+
+  const runResult = SetPipelineVariablesCommand.run(['8', '--variable', 'foo', ''])
+  await expect(runResult instanceof Promise).toBeTruthy()
+  await expect(runResult).rejects.toEqual(new Error('Blank variable values are not allowed. Use the proper flag if you intend to delete a variable.'))
+})
+
 test('set-pipeline-variables - bad secret flag', async () => {
   setCurrentOrgId('good')
   setStore({