fix(commerce): always pass all arguments to commerce command API. fixes #552

Author: rwalter215

src/commands/cloudmanager/commerce/bin-magento/cache/clean.js

@@ -21,13 +21,12 @@ class CacheCleanCommand extends BaseCommerceCliCommand {
     const { flags, argv } = this.parse(CacheCleanCommand)
 
     const programId = getProgramId(flags)
-    const cacheTypes = argv.slice(1)
 
     const result = await this.runSync(programId, flags.environmentId,
       {
         type: 'bin/magento',
         command: 'cache:clean',
-        options: ['-n', ...cacheTypes, ...getFormattedFlags(flags, CacheCleanCommand)],
+        options: ['-n', ...argv, ...getFormattedFlags(flags, CacheCleanCommand)],
       },
       1000, 'cache:clean')
 

src/commands/cloudmanager/commerce/bin-magento/cache/flush.js

@@ -21,13 +21,12 @@ class CacheFlushCommand extends BaseCommerceCliCommand {
     const { flags, argv } = this.parse(CacheFlushCommand)
 
     const programId = getProgramId(flags)
-    const cacheTypes = argv.slice(1)
 
     const result = await this.runSync(programId, flags.environmentId,
       {
         type: 'bin/magento',
         command: 'cache:flush',
-        options: ['-n', ...cacheTypes, ...getFormattedFlags(flags, CacheFlushCommand)],
+        options: ['-n', ...argv, ...getFormattedFlags(flags, CacheFlushCommand)],
       },
       1000, 'cache:flush')
 

src/commands/cloudmanager/commerce/bin-magento/indexer/reindex.js

@@ -21,13 +21,12 @@ class IndexerReindexCommand extends BaseCommerceCliCommand {
     const { flags, argv } = this.parse(IndexerReindexCommand)
 
     const programId = getProgramId(flags)
-    const indexTypes = argv.slice(1)
 
     const result = await this.runSync(programId, flags.environmentId,
       {
         type: 'bin/magento',
         command: 'indexer:reindex',
-        options: ['-n', ...indexTypes, ...getFormattedFlags(flags, IndexerReindexCommand)],
+        options: ['-n', ...argv, ...getFormattedFlags(flags, IndexerReindexCommand)],
       },
       1000, 'indexer:reindex')
 

test/commands/commerce/bin-magento/cache/clean.test.js

@@ -38,15 +38,15 @@ test('cache:clean - missing arg', async () => {
   await expect(runResult).rejects.toThrow(/^Missing required flag/)
 })
 
-test('maintenance:status - missing config', async () => {
+test('cache:clean - missing config', async () => {
   expect.assertions(2)
 
   const runResult = run(['--programId', '5', '--environmentId', '10'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await expect(runResult).rejects.toThrow('[CloudManagerCLI:NO_IMS_CONTEXT] Unable to find IMS context aio-cli-plugin-cloudmanager.')
 })
 
-test('maintenance:status', async () => {
+test('cache:clean', async () => {
   let counter = 0
   setCurrentOrgId('good')
   mockSdk.postCommerceCommandExecution = jest.fn(() =>
@@ -75,7 +75,7 @@ test('maintenance:status', async () => {
 
   expect.assertions(11)
 
-  const runResult = run(['--programId', '5', '--environmentId', '10', '-V', '--ansi'])
+  const runResult = run(['--programId', '5', '--environmentId', '10', '-V', '--ansi', 'cacheType1', 'cacheType2'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await runResult
   await expect(init.mock.calls.length).toEqual(1)
@@ -89,7 +89,7 @@ test('maintenance:status', async () => {
   await expect(mockSdk.postCommerceCommandExecution).toHaveBeenCalledWith('5', '10', {
     type: 'bin/magento',
     command: 'cache:clean',
-    options: ['-n', '--version', '--ansi'],
+    options: ['-n', 'cacheType1', 'cacheType2', '--version', '--ansi'],
   })
   await expect(mockSdk.getCommerceCommandExecution).toHaveBeenCalledWith('5', '10', '5000')
   await expect(mockSdk.getCommerceCommandExecution).toHaveBeenCalledTimes(3)

test/commands/commerce/bin-magento/cache/flush.test.js

@@ -38,15 +38,15 @@ test('cache:flush - missing environemtId', async () => {
   await expect(runResult).rejects.toThrow(/^Missing required flag/)
 })
 
-test('maintenance:status - missing config', async () => {
+test('cache:flush - missing config', async () => {
   expect.assertions(2)
 
   const runResult = run(['--programId', '5', '--environmentId', '10'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await expect(runResult).rejects.toThrow('[CloudManagerCLI:NO_IMS_CONTEXT] Unable to find IMS context aio-cli-plugin-cloudmanager.')
 })
 
-test('maintenance:status', async () => {
+test('cache:flush', async () => {
   let counter = 0
   setCurrentOrgId('good')
   mockSdk.postCommerceCommandExecution = jest.fn(() =>
@@ -75,7 +75,7 @@ test('maintenance:status', async () => {
 
   expect.assertions(11)
 
-  const runResult = run(['--programId', '5', '--environmentId', '10', '--no-ansi'])
+  const runResult = run(['--programId', '5', '--environmentId', '10', '--no-ansi', 'cacheType1', 'cacheType2'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await runResult
   await expect(init.mock.calls.length).toEqual(1)
@@ -89,7 +89,7 @@ test('maintenance:status', async () => {
   await expect(mockSdk.postCommerceCommandExecution).toHaveBeenCalledWith('5', '10', {
     type: 'bin/magento',
     command: 'cache:flush',
-    options: ['-n', '--no-ansi'],
+    options: ['-n', 'cacheType1', 'cacheType2', '--no-ansi'],
   })
   await expect(mockSdk.getCommerceCommandExecution).toHaveBeenCalledWith('5', '10', '5000')
   await expect(mockSdk.getCommerceCommandExecution).toHaveBeenCalledTimes(3)

test/commands/commerce/bin-magento/indexer/reindex.test.js

@@ -38,15 +38,15 @@ test('indexer:reindex - missing arg', async () => {
   await expect(runResult).rejects.toThrow(/^Missing required flag/)
 })
 
-test('maintenance:status - missing config', async () => {
+test('indexer:reindex - missing config', async () => {
   expect.assertions(2)
 
   const runResult = run(['--programId', '5', '--environmentId', '10'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await expect(runResult).rejects.toThrow('[CloudManagerCLI:NO_IMS_CONTEXT] Unable to find IMS context aio-cli-plugin-cloudmanager.')
 })
 
-test('maintenance:status', async () => {
+test('indexer:reindex', async () => {
   let counter = 0
   setCurrentOrgId('good')
   mockSdk.postCommerceCommandExecution = jest.fn(() =>
@@ -75,7 +75,7 @@ test('maintenance:status', async () => {
 
   expect.assertions(11)
 
-  const runResult = run(['--programId', '5', '--environmentId', '10'])
+  const runResult = run(['--programId', '5', '--environmentId', '10', 'index1', 'index2'])
   await expect(runResult instanceof Promise).toBeTruthy()
   await runResult
   await expect(init.mock.calls.length).toEqual(1)
@@ -89,7 +89,7 @@ test('maintenance:status', async () => {
   await expect(mockSdk.postCommerceCommandExecution).toHaveBeenCalledWith('5', '10', {
     type: 'bin/magento',
     command: 'indexer:reindex',
-    options: ['-n'],
+    options: ['-n', 'index1', 'index2'],
   })
   await expect(mockSdk.getCommerceCommandExecution).toHaveBeenCalledWith('5', '10', '5000')
   await expect(mockSdk.getCommerceCommandExecution).toHaveBeenCalledTimes(3)