chore: remove unnecessary async usage (#296)

Author: justinedelson

src/base-variables-command.js

@@ -50,7 +50,7 @@ class BaseVariablesCommand extends Command {
   }
 
   async runSet (args, flags) {
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     const currentVariablesList = await this.getVariables(programId, args, flags.imsContextName)
 

src/cloudmanager-helpers.js

@@ -27,14 +27,14 @@ function toJson (item) {
   return c
 }
 
-async function getBaseUrl () {
-  const configStr = await Config.get('cloudmanager')
+function getBaseUrl () {
+  const configStr = Config.get('cloudmanager')
 
   return (configStr && toJson(configStr).base_url) || 'https://cloudmanager.adobe.io'
 }
 
-async function getProgramId (flags) {
-  const programId = flags.programId || await Config.get('cloudmanager_programid')
+function getProgramId (flags) {
+  const programId = flags.programId || Config.get('cloudmanager_programid')
   if (!programId) {
     throw new Error('Program ID must be specified either as --programId flag or through cloudmanager_programid config value')
   }
@@ -96,8 +96,8 @@ function sanitizeEnvironmentId (environmentId) {
   return envId
 }
 
-async function getDefaultEnvironmentId (flags) {
-  return await Config.get('cloudmanager_environmentid')
+function getDefaultEnvironmentId (flags) {
+  return Config.get('cloudmanager_environmentid')
 }
 
 async function initSdk (contextName) {
@@ -112,7 +112,7 @@ async function initSdk (contextName) {
 
   const accessToken = await getToken(contextName)
 
-  const baseUrl = await getBaseUrl()
+  const baseUrl = getBaseUrl()
   return await init(orgId, apiKey, accessToken, baseUrl)
 }
 

src/commands/cloudmanager/current-execution/advance.js

@@ -19,7 +19,7 @@ class AdvanceCurrentExecutionCommand extends Command {
   async run () {
     const { args, flags } = this.parse(AdvanceCurrentExecutionCommand)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     let result
 

src/commands/cloudmanager/current-execution/cancel.js

@@ -19,7 +19,7 @@ class CancelCurrentExecutionCommand extends Command {
   async run () {
     const { args, flags } = this.parse(CancelCurrentExecutionCommand)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     let result
 

src/commands/cloudmanager/current-execution/get.js

@@ -18,7 +18,7 @@ class GetCurrentExecutionCommand extends BaseExecutionCommand {
   async run () {
     const { args, flags } = this.parse(GetCurrentExecutionCommand)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     let result
 

src/commands/cloudmanager/environment/bind-ip-allowlist.js

@@ -21,7 +21,7 @@ class BindIPAllowlist extends Command {
   async run () {
     const { flags, args } = this.parse(BindIPAllowlist)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     cli.action.start(`binding IP allowlist ${args.ipAllowlistId} to environment ${args.environmentId} (${args.service})`)
 

src/commands/cloudmanager/environment/delete.js

@@ -19,7 +19,7 @@ class DeleteEnvironmentCommand extends Command {
   async run () {
     const { args, flags } = this.parse(DeleteEnvironmentCommand)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     const environmentId = sanitizeEnvironmentId(args.environmentId)
 

src/commands/cloudmanager/environment/download-logs.js

@@ -20,7 +20,7 @@ class DownloadLogs extends Command {
   async run () {
     const { args, flags } = this.parse(DownloadLogs)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     const environmentId = sanitizeEnvironmentId(args.environmentId)
 

src/commands/cloudmanager/environment/list-available-log-options.js

@@ -19,7 +19,7 @@ class ListAvailableLogOptionsCommand extends Command {
   async run () {
     const { args, flags } = this.parse(ListAvailableLogOptionsCommand)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     const environmentId = sanitizeEnvironmentId(args.environmentId)
 

src/commands/cloudmanager/environment/list-ip-allowlist-bindings.js

@@ -21,7 +21,7 @@ class ListIPAllowlistBindings extends Command {
   async run () {
     const { flags, args } = this.parse(ListIPAllowlistBindings)
 
-    const programId = await getProgramId(flags)
+    const programId = getProgramId(flags)
 
     let result