chore(renovate): Update dependency @biomejs/biome (#23)

* chore(renovate): Update dependency @biomejs/biome

* refactor: fix biome upgrade issues

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ivan Porto <iporto@adobe.com>

Author: renovate[bot]

biome.jsonc

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/2.1.3/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.2.2/schema.json",
   "extends": ["ultracite"],
 
   "files": {
@@ -38,6 +38,19 @@
     }
   },
 
+  "overrides": [
+    {
+      "includes": ["tests/**/*"],
+      "linter": {
+        "rules": {
+          "style": {
+            "noMagicNumbers": "off"
+          }
+        }
+      }
+    }
+  ],
+
   "assist": {
     "actions": {
       "source": {

package-lock.json

@@ -92,7 +92,7 @@
     "winston-transport": "^4.9.0"
   },
   "devDependencies": {
-    "@biomejs/biome": "2.1.3",
+    "@biomejs/biome": "2.2.0",
     "@changesets/changelog-github": "0.5.1",
     "@changesets/cli": "2.29.5",
     "@tsconfig/node-lts": "^22.0.2",

package.json

@@ -26,14 +26,22 @@ import type { TelemetryDiagnosticsConfig } from "~/types";
 // If no log level is given, use [INFO].
 const DEFAULT_LOG_LEVEL = "info";
 
+type GetLoggerInternalConfig = {
+  name: string;
+  config?: AioLoggerConfig;
+  forceSDKInitialized?: boolean;
+  addTransport?: boolean;
+  telemetryTransportOptions?: Transport.TransportStreamOptions;
+};
+
 /** @internal */
-function __getLoggerInternal(
-  name: string,
-  config?: AioLoggerConfig,
+function __getLoggerInternal({
+  name,
+  config,
   forceSDKInitialized = true,
   addTransport = true,
-  telemetryTransportOptions: Transport.TransportStreamOptions = {},
-) {
+  telemetryTransportOptions = {},
+}: GetLoggerInternalConfig) {
   if (forceSDKInitialized) {
     ensureSdkInitialized();
   }
@@ -76,7 +84,7 @@ function __getLoggerInternal(
  * ```
  */
 export function getLogger(name: string, config?: AioLoggerConfig) {
-  return __getLoggerInternal(name, config, true);
+  return __getLoggerInternal({ name, config, forceSDKInitialized: true });
 }
 
 /**
@@ -98,21 +106,23 @@ export function setOtelDiagLogger({
 
   const aioLogLevel = logLevels[level] ?? level;
   const { actionName } = getRuntimeActionMetadata();
-  const logger = __getLoggerInternal(
-    loggerName ?? `${actionName}/otel-diagnostics`,
-    {
+  const logger = __getLoggerInternal({
+    name: loggerName ?? `${actionName}/otel-diagnostics`,
+    config: {
       level: aioLogLevel,
       logSourceAction: false,
     },
-    false,
-    exportLogs,
+    forceSDKInitialized: false,
+    addTransport: exportLogs,
+
     // Only use the OpenTelemetry transport (i.e. export diagnostic logs) if the log level is
     // set to info, warn or error. The other levels are too verbose to be exported and may expose
     // irrelevant/sensitive information. All logs will still be visible via `aio rt activation logs <id>`.
-    level === "info" || level === "warn" || level === "error"
-      ? { level }
-      : { level: "info" },
-  );
+    telemetryTransportOptions:
+      level === "info" || level === "warn" || level === "error"
+        ? { level }
+        : { level: "info" },
+  });
 
   // Wrap the logger in a DiagLogger compatible interface.
   const logLevel = level.toUpperCase() as keyof typeof DiagLogLevel;

source/core/logging.ts

@@ -59,6 +59,7 @@ export function defineMetrics<T extends Record<PropertyKey, MetricTypes>>(
   // This way we can defer the initialization of the metrics until the telemetry API (meter) is initialized.
   return new Proxy({} as T, {
     get(_, prop: PropertyKey) {
+      // biome-ignore lint/nursery/noUnnecessaryConditions: False positive
       if (isInitializing) {
         // Would happen if using a metric inside the `defineMetrics` function.
         throw new Error(

source/core/metrics.ts

@@ -10,6 +10,7 @@
  * governing permissions and limitations under the License.
  */
 
+/** biome-ignore-all lint/performance/noBarrelFile: This is the import entrypoint for the public API. */
 // This file collects and exports all the public API of the telemetry module.
 
 export {

source/index.ts

@@ -14,6 +14,8 @@
 // It provides core APIs, SDKs, exporters, and resources while omitting
 // specialized packages like individual instrumentations and similar utilities.
 
+/** biome-ignore-all lint/performance/noBarrelFile: This is the import entrypoint for the public API. */
+
 export * from "@opentelemetry/api";
 export * from "@opentelemetry/api-logs";
 export { OTLPLogExporter as OTLPLogExporterGrpc } from "@opentelemetry/exporter-logs-otlp-grpc";

source/otel.ts

@@ -38,7 +38,7 @@ export type TelemetryInstrumentationPreset = "simple" | "full";
  * The configuration for the telemetry diagnostics.
  * @since 0.1.0
  */
-export interface TelemetryDiagnosticsConfig {
+export type TelemetryDiagnosticsConfig = {
   /**
    * The log level to use for the diagnostics.
    * @since 0.1.0
@@ -61,13 +61,13 @@ export interface TelemetryDiagnosticsConfig {
    * @since 0.1.0
    */
   exportLogs?: boolean;
-}
+};
 
 /**
  * Configuration related to context propagation (for distributed tracing).
  * @since 0.1.0
  */
-export interface TelemetryPropagationConfig {
+export type TelemetryPropagationConfig = {
   /**
    * By default, an instrumented entrypoint will try to automatically read (and use) the context from the incoming request.
    * Set to `true` if you want to skip this automatic context propagation.
@@ -90,13 +90,13 @@ export interface TelemetryPropagationConfig {
     carrier: Record<PropertyKey, string>;
     baseCtx?: Context;
   };
-}
+};
 
 /**
  * The configuration for instrumentation.
  * @since 0.1.0
  */
-export interface InstrumentationConfig<T extends AnyFunction> {
+export type InstrumentationConfig<T extends AnyFunction> = {
   /**
    * Configuration options related to the span started by the instrumented function.
    * See also the [SpanOptions](https://open-telemetry.github.io/opentelemetry-js/interfaces/_opentelemetry_api._opentelemetry_api.SpanOptions.html) interface.
@@ -158,7 +158,7 @@ export interface InstrumentationConfig<T extends AnyFunction> {
      */
     onError?: (error: unknown, span: Span) => Error | undefined;
   };
-}
+};
 
 /**
  * The configuration options for the telemetry module.
@@ -213,7 +213,7 @@ export interface EntrypointInstrumentationConfig
  * Defines the global telemetry API. These items should be set once per application.
  * @since 0.1.0
  */
-export interface TelemetryApi {
+export type TelemetryApi = {
   /**
    * The tracer used to create spans.
    * @since 0.1.0
@@ -225,13 +225,13 @@ export interface TelemetryApi {
    * @since 0.1.0
    */
   meter: Meter;
-}
+};
 
 /**
  * The context for the current operation.
  * @since 0.1.0
  */
-export interface InstrumentationContext {
+export type InstrumentationContext = {
   /**
    * The global (managed by the library) tracer instance used to create spans.
    * @since 0.1.0
@@ -261,4 +261,4 @@ export interface InstrumentationContext {
    * @since 0.1.0
    */
   contextCarrier: Record<PropertyKey, string>;
-}
+};

source/types.ts

@@ -58,6 +58,6 @@ export function setupProductionEnv() {
 
   // The `__OW_DEADLINE` env var represents the timestamp (in ms)
   // by which the action execution must be completed.
-  const oneMonthInMilliseconds = 30 * 24 * 60 * 60 * 1000;
+  const oneMonthInMilliseconds = 2_592_000_000;
   vi.stubEnv("__OW_DEADLINE", `${Date.now() + oneMonthInMilliseconds}`);
 }

tests/fixtures/environment.ts

@@ -27,7 +27,9 @@ describe("api/presets", () => {
     test("should return simple instrumentations for 'simple' preset", () => {
       const instrumentations = apiPresets.getPresetInstrumentations("simple");
       expect(Array.isArray(instrumentations)).toBe(true);
-      expect(instrumentations).toHaveLength(3);
+
+      const expectedInstrumentations = 3;
+      expect(instrumentations).toHaveLength(expectedInstrumentations);
 
       const instrumentationNames = instrumentations.map(
         (i) => i.instrumentationName,