fixed clickthrough handling for duplicate s_kwcid/ef_id query params (#1443)

* test: add duplicate s_kwcid regression coverage

* fix: normalize duplicate s_kwcid values

* fix: remove redundant code

* chore: add changeset

Author: carterworks

.changeset/shaky-lines-flash.md

@@ -0,0 +1,5 @@
+---
+"@adobe/alloy": patch
+---
+
+Fixed an issue where there are multiple s_kwcid or ef_id parameters in url"

packages/core/src/components/Advertising/handlers/clickThroughHandler.js

@@ -28,8 +28,8 @@ import {
  * @param {Object} params.cookieManager - Session manager for cookie operations
  * @param {Object} params.adConversionHandler - Handler for sending ad conversion events
  * @param {Object} params.logger - Logger instance
- * @param {string} params.skwcid - Search keyword click ID
- * @param {string} params.efid - EF ID parameter
+ * @param {string | string[]} params.skwcid - Search keyword click ID
+ * @param {string | string[]} params.efid - EF ID parameter
  * @param {Object} params.optionsFromCommand - Additional options from command
  * @returns {Promise} Result of the ad conversion tracking
  */
@@ -38,10 +38,13 @@ export default async function handleClickThrough({
   cookieManager,
   adConversionHandler,
   logger,
-  skwcid,
-  efid,
+  skwcid: rawSkwcid,
+  efid: rawEfId,
 }) {
-  logger.info(LOG_AD_CONVERSION_START, { skwcid, efid });
+  const skwcid = Array.isArray(rawSkwcid) ? rawSkwcid[0] : rawSkwcid;
+  const efid = Array.isArray(rawEfId) ? rawEfId[0] : rawEfId;
+
+  logger.info(LOG_AD_CONVERSION_START, { skwcid: skwcid, efid });
 
   const event = eventManager.createEvent();
   if (
@@ -51,8 +54,8 @@ export default async function handleClickThrough({
   ) {
     const clickData = {
       click_time: Date.now(),
-      ...(typeof skwcid !== "undefined" && { skwcid }),
-      ...(typeof efid !== "undefined" && { efid }),
+      skwcid,
+      efid,
     };
     cookieManager.setValue(LAST_CLICK_COOKIE_KEY, clickData);
   }
@@ -61,7 +64,9 @@ export default async function handleClickThrough({
     _experience: {
       adcloud: {
         conversionDetails: {
-          ...(typeof skwcid !== "undefined" && { [TRACKING_CODE]: skwcid }),
+          ...(typeof skwcid !== "undefined" && {
+            [TRACKING_CODE]: skwcid,
+          }),
           ...(typeof efid !== "undefined" && {
             [TRACKING_IDENTITIES]: efid,
           }),

packages/core/test/integration/specs/Advertising/clickthrough_duplicate_skwcid.spec.js

@@ -0,0 +1,44 @@
+/*
+Copyright 2025 Adobe. All rights reserved.
+This file is licensed to you under the Apache License, Version 2.0 (the "License");
+*/
+
+import { test, describe, expect } from "../../helpers/testsSetup/extend.js";
+import { sendEventHandler } from "../../helpers/mswjs/handlers.js";
+import alloyConfig from "../../helpers/alloy/config.js";
+import {
+  createAdvertisingConfig,
+  findClickThroughCall,
+  validateClickThroughCall,
+} from "../../helpers/advertising.js";
+
+describe("Advertising - Clickthrough (duplicate s_kwcid)", () => {
+  test("should use the first s_kwcid value when duplicates are present", async ({
+    alloy,
+    worker,
+    networkRecorder,
+  }) => {
+    worker.use(...[sendEventHandler]);
+
+    const url = new URL(window.location.origin + window.location.pathname);
+    url.searchParams.append("s_kwcid", "AL!first-keyword");
+    url.searchParams.append("s_kwcid", "AL!second-keyword");
+    url.searchParams.set("ef_id", "test_experiment_456");
+    window.history.replaceState({}, "", url.toString());
+
+    await alloy("configure", {
+      ...alloyConfig,
+      ...createAdvertisingConfig(),
+    });
+
+    await alloy("sendEvent");
+
+    const calls = await networkRecorder.findCalls(/edge\.adobedc\.net/);
+    const conversionCall = findClickThroughCall(calls);
+    expect(conversionCall).toBeTruthy();
+    validateClickThroughCall(conversionCall, {
+      sampleGroupId: "AL!first-keyword",
+      experimentId: "test_experiment_456",
+    });
+  });
+});

packages/core/test/unit/specs/components/Advertising/handlers/clickThroughHandler.spec.js

@@ -332,4 +332,41 @@ describe("Advertising::clickThroughHandler", () => {
 
     expect(logger.error).toHaveBeenCalled();
   });
+
+  it("should handle duplicate s_kwcid values by using the first value", async () => {
+    const mockEvent = {
+      setUserXdm: vi.fn(),
+      finalize: vi.fn(),
+    };
+    eventManager.createEvent.mockReturnValue(mockEvent);
+
+    const result = await handleClickThrough({
+      eventManager,
+      cookieManager,
+      adConversionHandler,
+      logger,
+      skwcid: ["AL!first-value", "AL!second-value"],
+      efid: "test-efid",
+      optionsFromCommand: {},
+    });
+
+    expect(mockEvent.setUserXdm).toHaveBeenCalledWith(
+      expect.objectContaining({
+        _experience: {
+          adcloud: {
+            conversionDetails: {
+              trackingCode: "AL!first-value",
+              trackingIdentities: "test-efid",
+            },
+          },
+        },
+      }),
+    );
+    expect(cookieManager.setValue).toHaveBeenCalledWith(LAST_CLICK_COOKIE_KEY, {
+      click_time: expect.anything(),
+      skwcid: "AL!first-value",
+      efid: "test-efid",
+    });
+    expect(result).toEqual({ status: "success" });
+  });
 });