Commit e27bf44
authored
Added consent gating to the Advertising component to ensure no advertising cookies are written before user consent is resolved. (#1442)
* fix functional tests
updated the skipped tests for helper.js
in componentRegistered hook , for viewthru : return promise for click thru advertising call , for viewthru case fire and forget
Add timestamp in payload of enrichment calls
* click thru check -> either one of ef_id or s_kwcid param present
* build trigger
* build trigger
* build trigger
* build trigger
* consent bug fix : advertising component
* Remove sandbox file changes from branch
* Remove unrelated files from branch - keep only consent changes
* feat(Advertising): gate click cookie write on consent
Move LAST_CLICK_COOKIE_KEY cookie write from clickThroughHandler into
createAdConversionHandler.trackAdConversion(), after consent.awaitConsent()
resolves. This ensures no ad-tracking cookies (skwcid/efid) are set
without user consent.
Changes:
- clickThroughHandler: removed pre-consent LAST_CLICK_COOKIE_KEY write,
pass skwcid/efid through to trackAdConversion()
- createAdConversionHandler: accept cookieManager, write click cookie
only after consent is granted
- index.js: pass cookieManager to createAdConversionHandler (1-line change)
* consent case for onbefore send event
* consent case for onbefore send event
* add changeset for advertising consent gate1 parent 9cf47f9 commit e27bf44
File tree
4 files changed
+35
-0
lines changed- .changeset
- packages/core
- src/components/Advertising
- test/unit/specs/components/Advertising
- utils
4 files changed
+35
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
| |||
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| |||
143 | 144 | | |
144 | 145 | | |
145 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
146 | 167 | | |
147 | 168 | | |
148 | 169 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
50 | 52 | | |
51 | 53 | | |
52 | 54 | | |
| |||
0 commit comments